Skip to content

[codex] Deduplicate connection failure messaging#4367

Merged
juliusmarminge merged 1 commit into
mainfrom
codex/deduplicate-connection-error
Jul 23, 2026
Merged

[codex] Deduplicate connection failure messaging#4367
juliusmarminge merged 1 commit into
mainfrom
codex/deduplicate-connection-error

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Jul 23, 2026

Copy link
Copy Markdown
Member

Connection failures currently repeat the same supervisor error in the composer banner title, banner body, and disabled composer placeholder. This makes the failure state noisy and makes the actual reason harder to scan.

The banner title used connectionStatusText, which intentionally includes the latest low-level reason, while the banner description also rendered that reason. The composer independently reused the same combined status string as its placeholder.

This change adds a concise connection-status title presentation, keeps the underlying failure reason in the banner description, and leaves the normal composer placeholder unchanged while sending remains unavailable.

Verification:

  • vp lint --report-unused-disable-directives on the changed files
  • client-runtime and web typechecks
  • focused connection presentation tests (8 passing)

Note

Low Risk
Presentation-only changes to connection messaging in the web UI; no changes to connection logic or send gating beyond placeholder copy.

Overview
Connection failure copy was repeated in the composer banner title, banner body, and disabled composer placeholder. This PR adds connectionStatusTitle in client-runtime so titles stay short (e.g. reconnecting omits the Reason: … line that connectionStatusText still includes).

ChatView uses the new helper for the environment-unavailable banner title while the description still shows connection.error. ChatComposer no longer injects connection status into the textarea placeholder when the environment is down—it uses the usual placeholders instead.

Reviewed by Cursor Bugbot for commit 221377f. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Deduplicate connection failure messaging in chat banner and composer

  • Introduces connectionStatusTitle in presentation.ts, which returns a concise title (e.g. Failed to connect. Reconnecting...) that suppresses error details, delegating to connectionStatusText with error forced to null otherwise.
  • Updates the system composer banner in ChatView.tsx to use connectionStatusTitle instead of connectionStatusText, removing the redundant error reason from the banner title.
  • Removes the environmentUnavailable placeholder branch from ChatComposer.tsx, so the composer no longer shows connection status text in the textarea placeholder when the environment is unavailable.

Macroscope summarized 221377f.

Co-authored-by: codex <codex@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: da025263-61b3-4ae3-b472-3da74a0e7d0a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/deduplicate-connection-error

Comment @coderabbitai help to get the list of available commands.

@juliusmarminge
juliusmarminge marked this pull request as ready for review July 23, 2026 12:42
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Jul 23, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

This PR adds a helper function for shorter connection status titles and removes a redundant placeholder message from the chat composer. The changes are self-contained UI text cleanup with no complex logic or risky side effects.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit 315b273 into main Jul 23, 2026
22 of 25 checks passed
@juliusmarminge
juliusmarminge deleted the codex/deduplicate-connection-error branch July 23, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant