Skip to content

[codex] restore Sidebar V2 project actions#4373

Merged
juliusmarminge merged 3 commits into
mainfrom
codex/sidebar-v2-project-actions
Jul 23, 2026
Merged

[codex] restore Sidebar V2 project actions#4373
juliusmarminge merged 3 commits into
mainfrom
codex/sidebar-v2-project-actions

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Jul 23, 2026

Copy link
Copy Markdown
Member

What changed

Sidebar V2 now exposes the project-entry actions that were available in Sidebar V1 without treating a logical project group as one indivisible destructive target.

The project ellipsis closes the scope menu, then opens one project settings dialog. Each physical entry is clearly labeled by environment and workspace path, with its project name and grouping rule editable inline. Copy path and Remove stay available per entry; removing every member remains an explicit, secondary Remove all entries action.

Single projects use the same dialog with one entry. Rename uses the existing server update command, while grouping changes update the existing grouping override settings directly.

Why

The previous Sidebar V2 trash button immediately targeted the entire logical group. Once local and remote project records were grouped, users could no longer rename, regroup, copy, or remove one physical project independently, and the default removal confirmation could delete every grouped entry and its conversation history.

Verification

  • vp lint apps/web/src/components/SidebarV2.tsx
  • vp test run apps/web/src/components/Sidebar.logic.test.ts apps/web/src/environmentGrouping.test.ts
  • vp run --filter @t3tools/web typecheck
  • React Doctor review of the changed web scope (reported pre-existing Sidebar V2/compiler diagnostics; no new dialog-specific issue)
  • Integrated browser verification against two disposable environments labeled Grouping Remote and Grouping Local
  • Verified the scope menu is dismissed before the dialog mounts
  • Verified the desktop dialog exposes both inline project-name inputs and grouping selects

Note

Medium Risk
Changes destructive project removal UX and adds server-backed rename plus client grouping overrides, but reuses existing commands and settings patterns from Sidebar V1.

Overview
Sidebar V2’s project scope menu no longer removes an entire logical group from a trash icon. Each project row gets an ellipsis that dismisses the scope menu and opens a Project settings dialog.

The dialog is per physical entry (environment + path): inline rename via projectEnvironment.update, grouping rule overrides via client settings, copy path, and remove for that entry only. Multi-member groups also show an explicit Remove all entries footer.

Removal logic is refactored to handleRemoveProjectMembers with a member subset, so confirmations name the specific entry (path/environment) and clarify when other grouped entries stay untouched.

Reviewed by Cursor Bugbot for commit ef27faf. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Restore project actions in Sidebar V2 with logical project grouping

  • Adds sortLogicalProjectsForSidebar to sort grouped cross-environment projects by manual order or recent activity, ignoring archived threads.
  • Updates SidebarV2.tsx to group projects by logical key, filter threads by scoped project membership, and apply manual ordering when the sort order is 'manual'.
  • Replaces the direct trash-icon delete with an ellipsis actions menu that opens a dialog supporting per-environment rename, grouping rule override, copy path, single-entry removal, and bulk removal of all grouped entries.
  • Extends buildSidebarProjectSnapshots so memberProjectRefs includes all scoped project references mapping to a logical group, and adds buildSidebarProjectPickerEntries to select a preferred-environment target per group.

Macroscope summarized 1d596b3.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: fb9bdd15-d1ef-47c0-b521-484e190f7af7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/sidebar-v2-project-actions

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Jul 23, 2026
@juliusmarminge
juliusmarminge marked this pull request as ready for review July 23, 2026 15:59

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but a cloud agent failed to start.

Reviewed by Cursor Bugbot for commit 493abfa. Configure here.

Comment thread apps/web/src/components/SidebarV2.tsx
@macroscopeapp

macroscopeapp Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR adds new user-facing features including project rename, grouping preference management, and a new project actions dialog. The scope of new functionality and user workflows warrants human review.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge changed the base branch from codex/sidebar-v2-grouped-filter to main July 23, 2026 16:07
juliusmarminge and others added 3 commits July 23, 2026 18:07
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge force-pushed the codex/sidebar-v2-project-actions branch from 1d596b3 to ef27faf Compare July 23, 2026 16:07
@juliusmarminge
juliusmarminge enabled auto-merge (squash) July 23, 2026 16:07
@juliusmarminge
juliusmarminge merged commit 57100fb into main Jul 23, 2026
16 checks passed
@juliusmarminge
juliusmarminge deleted the codex/sidebar-v2-project-actions branch July 23, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant