Polish iOS git progress overlay with glass effects#4387
Conversation
- Forward refs through GlassSurface for animated glass overlays - Add iOS glass styling with an animated fallback for unsupported platforms
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
size:M
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| > | ||
| <View className="flex-row items-center gap-2.5 px-3.5 py-3">{content}</View> | ||
| </AnimatedGlassSurface> | ||
| ); |
There was a problem hiding this comment.
Error chrome missing on glass path
Medium Severity
After the glass branch was added, progress.phase === "error" no longer affects the overlay shell on iOS when the glass API is available. The red background and border from bgClass apply only on the fallback Animated.View, so failed git actions on that path lose the full-card error treatment they had before this change.
Reviewed by Cursor Bugbot for commit faf65cb. Configure here.
ApprovabilityVerdict: Needs human review An unresolved review comment identifies a bug where error state styling (red background/border) is missing on the iOS glass effect path, causing error feedback to be lost for those users. This should be addressed before merging. You can customize Macroscope's approvability policy. Learn more. |
- Use Liquid Glass for the git action progress overlay - Avoid forwarding refs through GlassSurface on unsupported glass APIs
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit cb8041b. Configure here.
| {content} | ||
| </Animated.View> | ||
| </AnimatedLiquidGlassView> | ||
| </Animated.View> |
There was a problem hiding this comment.
Expo glass fallback removed
Medium Severity
The overlay now branches only on isLiquidGlassSupported, so iOS devices where expo-glass-effect is available but liquid glass is not always get the bordered fallback instead of native glass. The prior AnimatedGlassSurface path used the same expo gate as GlassSurface and could still show glass above the thread header.
Reviewed by Cursor Bugbot for commit cb8041b. Configure here.
| colorScheme={isDarkMode ? "dark" : "light"} | ||
| effect="regular" | ||
| interactive | ||
| layout={OVERLAY_LAYOUT_TRANSITION} |
There was a problem hiding this comment.
Duplicate layout on liquid glass
Medium Severity
This overlay is the only callsite that wraps LiquidGlassView in Animated.createAnimatedComponent and applies layout={OVERLAY_LAYOUT_TRANSITION} on both the outer Animated.View and AnimatedLiquidGlassView. ComposerSurface animates only the wrapper and keeps LiquidGlassView non-animated.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit cb8041b. Configure here.
1 participant
Summary
GlassSurfacefor animated glass overlays.Testing
Note
Low Risk
Presentation-only changes to a progress toast; no git, auth, or data-path changes.
Overview
Git action progress overlay gets an iOS liquid-glass treatment when
@callstack/liquid-glassis supported, while other platforms keep the existing card/error styling.On supported devices,
OverlayContentwraps shared label/icon UI in an animatedLiquidGlassViewwith theme-driven tint and border (--color-glass-tint,--color-header-border), ~26px continuous corners, and a short inner fade-in. The outer overlay skips its fade-in on glass so the effect reads cleanly.Both glass and fallback paths use a 220ms
LinearTransitionon layout so the banner resizes smoothly as phase text changes. The non-glass branch still uses phase-based red/card classes but matches the updated corner radius.Reviewed by Cursor Bugbot for commit cb8041b. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Polish iOS git progress overlay with LiquidGlass effects
OverlayContentin GitActionProgressOverlay.tsx renders with an interactive glass effect, theme-derived tint/border, and a short delayedFadeInon content.Viewto anAnimated.View.LinearTransition.FadeInon entry when LiquidGlass is supported; otherwise retains the 200ms fade.Macroscope summarized cb8041b.