Restore model picker layout and retain iterative test state#4450
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved Pure CSS/styling changes to the model picker components - adjusting borders, background colors, and border radius. No logic or runtime behavior modifications, only visual layout adjustments. You can customize Macroscope's approvability policy. Learn more. |
## What's Changed * Increase light-mode contrast for user message bubbles by @juliusmarminge in pingdotgg/t3code#4441 * Restore model picker layout and retain iterative test state by @juliusmarminge in pingdotgg/t3code#4450 * Color settled PR labels on hover by @juliusmarminge in pingdotgg/t3code#4451 * [codex] Fix glass hover compositing artifacts by @juliusmarminge in pingdotgg/t3code#4446 **Full Changelog**: pingdotgg/t3code@v0.0.29-nightly.20260724.892...v0.0.29-nightly.20260724.893 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.29-nightly.20260724.893
What changed
test-t3-appguidance to retain authenticated dev environments across human iteration and tear them down only when review is actually finished.Why
The picker restyle changed more than the intended glass surface, and its rectangular popover viewport clipped the rounded inner surface at the bottom. During follow-up testing, eagerly tearing down the dev environment also discarded useful browser and application state between review turns.
User impact
The model picker again matches the prior layout while keeping the glass treatment, its lower corners render correctly in light mode, and iterative UI verification can retain server and browser state until explicitly completed.
Validation
vp fmt --check .agents/skills/test-t3-app/SKILL.md .agents/skills/test-t3-app/agents/openai.yaml apps/web/src/components/chat/ModelPickerContent.tsx apps/web/src/components/chat/ModelPickerSidebar.tsx apps/web/src/components/chat/ProviderModelPicker.tsxvp lint apps/web/src/components/chat/ModelPickerContent.tsx apps/web/src/components/chat/ModelPickerSidebar.tsx apps/web/src/components/chat/ProviderModelPicker.tsxvp run --filter @t3tools/web typecheckvp test run src/components/chat/modelPickerSearch.test.ts --project unit(7 tests)Note
Restore model picker layout and retain iterative test state across turns
lgradius), left border on main content when sidebar is visible, and search bar underline focus state inModelPickerContent.tsxModelPickerSidebar.tsxto show a right border and section divider under favorites with a lighter background tintlgradius inProviderModelPicker.tsxMacroscope summarized 02f531b.
Note
Low Risk
Cosmetic chat UI class changes and agent documentation only; no runtime logic, auth, or data paths.
Overview
Model picker styling is adjusted to bring back the prior hierarchy while keeping the glass surface: sidebar right border and lighter tint, muted list panel with a left divider when the rail is visible, and an underlined search field (replacing the accent search block) with subtler icon contrast. Corner radius moves to
rounded-lg, and the popover viewport is clipped to that radius so scrolled list content no longer shows sharp bottom corners.The
test-t3-appskill now tells agents to keep dev servers, ports, auth, and fixtures alive across review turns, reuse healthy environments on follow-ups, and tear down only when the user confirms the loop is done—not after each assistant response.Reviewed by Cursor Bugbot for commit 02f531b. Bugbot is set up for automated code reviews on this repo. Configure here.