Skip to content

Restore model picker layout and retain iterative test state#4450

Merged
juliusmarminge merged 1 commit into
mainfrom
agent/restore-model-picker-glass
Jul 24, 2026
Merged

Restore model picker layout and retain iterative test state#4450
juliusmarminge merged 1 commit into
mainfrom
agent/restore-model-picker-glass

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Jul 24, 2026

Copy link
Copy Markdown
Member

What changed

  • Restores the model picker’s previous visual hierarchy: sidebar dividers, muted list surface, and underlined search field.
  • Clips the Base UI popover viewport to the picker’s rounded boundary so scrolled content cannot expose sharp bottom corners.
  • Preserves the glass tint and backdrop blur instead of making the picker opaque or see-through.
  • Updates test-t3-app guidance to retain authenticated dev environments across human iteration and tear them down only when review is actually finished.

Why

The picker restyle changed more than the intended glass surface, and its rectangular popover viewport clipped the rounded inner surface at the bottom. During follow-up testing, eagerly tearing down the dev environment also discarded useful browser and application state between review turns.

User impact

The model picker again matches the prior layout while keeping the glass treatment, its lower corners render correctly in light mode, and iterative UI verification can retain server and browser state until explicitly completed.

Validation

  • vp fmt --check .agents/skills/test-t3-app/SKILL.md .agents/skills/test-t3-app/agents/openai.yaml apps/web/src/components/chat/ModelPickerContent.tsx apps/web/src/components/chat/ModelPickerSidebar.tsx apps/web/src/components/chat/ProviderModelPicker.tsx
  • vp lint apps/web/src/components/chat/ModelPickerContent.tsx apps/web/src/components/chat/ModelPickerSidebar.tsx apps/web/src/components/chat/ProviderModelPicker.tsx
  • vp run --filter @t3tools/web typecheck
  • vp test run src/components/chat/modelPickerSearch.test.ts --project unit (7 tests)
  • React Doctor: 91/100; only existing maintainability warnings
  • Integrated light-mode browser verification: search, model selection, restored composer layout, glass blur, and rounded lower corners

Note

Restore model picker layout and retain iterative test state across turns

  • Restores model picker popup styling: rounded corners (lg radius), left border on main content when sidebar is visible, and search bar underline focus state in ModelPickerContent.tsx
  • Updates ModelPickerSidebar.tsx to show a right border and section divider under favorites with a lighter background tint
  • Clips the popover viewport to lg radius in ProviderModelPicker.tsx
  • Updates the T3 app testing skill in SKILL.md to preserve dev server, ports, and browser sessions across turns rather than tearing down between each turn

Macroscope summarized 02f531b.


Note

Low Risk
Cosmetic chat UI class changes and agent documentation only; no runtime logic, auth, or data paths.

Overview
Model picker styling is adjusted to bring back the prior hierarchy while keeping the glass surface: sidebar right border and lighter tint, muted list panel with a left divider when the rail is visible, and an underlined search field (replacing the accent search block) with subtler icon contrast. Corner radius moves to rounded-lg, and the popover viewport is clipped to that radius so scrolled list content no longer shows sharp bottom corners.

The test-t3-app skill now tells agents to keep dev servers, ports, auth, and fixtures alive across review turns, reuse healthy environments on follow-ups, and tear down only when the user confirms the loop is done—not after each assistant response.

Reviewed by Cursor Bugbot for commit 02f531b. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-authored-by: codex <codex@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e9c7ce25-0fda-42bb-a9bb-b5a319be3c52

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/restore-model-picker-glass

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 24, 2026
@juliusmarminge
juliusmarminge marked this pull request as ready for review July 24, 2026 11:58
@macroscopeapp

macroscopeapp Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Pure CSS/styling changes to the model picker components - adjusting borders, background colors, and border radius. No logic or runtime behavior modifications, only visual layout adjustments.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit f7cc776 into main Jul 24, 2026
21 checks passed
@juliusmarminge
juliusmarminge deleted the agent/restore-model-picker-glass branch July 24, 2026 12:01
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Jul 24, 2026
## What's Changed
* Increase light-mode contrast for user message bubbles by @juliusmarminge in pingdotgg/t3code#4441
* Restore model picker layout and retain iterative test state by @juliusmarminge in pingdotgg/t3code#4450
* Color settled PR labels on hover by @juliusmarminge in pingdotgg/t3code#4451
* [codex] Fix glass hover compositing artifacts by @juliusmarminge in pingdotgg/t3code#4446


**Full Changelog**: pingdotgg/t3code@v0.0.29-nightly.20260724.892...v0.0.29-nightly.20260724.893

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.29-nightly.20260724.893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant