fix(web): keep worktree default when switching a draft's machine - #4964
Conversation
Switching the environment on a new-thread draft went through the projectChanged path in composerDraftStore, which reset envMode to "local" and startFromOrigin to false alongside the (correctly) cleared branch and worktree path. A user with defaultThreadEnvMode "worktree" who picked a different machine in the composer landed on "Current checkout" with whatever stale branch that machine had checked out. Branch and worktree path are machine-specific and still reset; env mode and start-from-origin are user intent and now carry across the switch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 63ce619 A straightforward bug fix that preserves user preferences (envMode and startFromOrigin) when switching a draft's machine/environment. The change is well-scoped to draft state management with updated tests documenting the expected behavior. You can customize Macroscope's approvability policy. Learn more. |
* fix(desktop): restore T3 Connect sign-in (pingdotgg#4809) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * Simplify files panel header (pingdotgg#4828) * build(desktop): reduce installed app size by ~300MB (pingdotgg#4824) * Update model version from claude-opus-4-8 to claude-opus-5 (pingdotgg#4832) * Preserve the thread shell while detail loads (pingdotgg#4830) * Reduce idle work and disk churn with native resource diagnostics (pingdotgg#2679) Co-authored-by: codex <codex@users.noreply.github.com> * fix(server): detect repositories after initialization (pingdotgg#4848) * perf(server): merge separate staged/unstaged numstat calls into single diff HEAD --numstat (pingdotgg#4843) * fix(git): disable external diff for review diff previews (pingdotgg#4854) * Fix editable file focus and live syntax highlighting (pingdotgg#3979) * fix(web): remember the rendered-markdown choice across threads (pingdotgg#4853) Co-authored-by: Simon Doba <simon.doba@orbit.de> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> * chore(release): prepare v0.0.31 * fix(mobile): reduce thread feed scroll jank (pingdotgg#4874) * fix(web): restore sidebar v2 thread actions and terminal icon (pingdotgg#4712) * fix(web): settle button now works on hover, not just right-click (pingdotgg#4905) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(clients): disable add project while disconnected (pingdotgg#4834) * fix(composer): hide default Codex service tier (pingdotgg#4784) * docs: link iOS and Android app store downloads (pingdotgg#4902) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(web): align remote server update action (pingdotgg#4731) * fix(connect): suggest a serve command that matches how you ran connect (pingdotgg#4897) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(mobile): stop shared content errors in Personal Team builds (pingdotgg#4943) * perf(mobile): sends respond instantly, thread opens stop freezing (pingdotgg#4882) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(web): show Codex fast mode as a bolt (pingdotgg#4947) * docs: seed worktrees with a copy of real userdata instead of banning it (pingdotgg#4949) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(mobile): support dragged images in the composer (pingdotgg#4953) * fix(mobile): stop long iOS threads from jumping while scrolling up (pingdotgg#4867) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(web): keep worktree default when switching a draft's machine (pingdotgg#4964) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * perf(mobile): reconnect environments immediately on resume (pingdotgg#4878) * feat(web): pasting a huge screenshot now compresses it instead of erroring (pingdotgg#4967) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(web): regenerate thread titles from sidebar (pingdotgg#4810) * fix(web): show server update progress through reconnect (pingdotgg#4903) --------- Co-authored-by: Alex <me@pixp.cc> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: wukko <me@wukko.me> Co-authored-by: codex <codex@users.noreply.github.com> Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com> Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com> Co-authored-by: ohbentos <72638975+ohbentos@users.noreply.github.com> Co-authored-by: Jake Leventhal <jakeleventhal@me.com> Co-authored-by: Simon Doba <simon.doba@hotmail.de> Co-authored-by: Simon Doba <simon.doba@orbit.de> Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com> Co-authored-by: Gabriel De Andrade <30420087+gabrielelpidio@users.noreply.github.com> Co-authored-by: Jono Kemball <Noojuno@users.noreply.github.com> Co-authored-by: Theo Browne <me@t3.gg> Co-authored-by: Max Katz <me@maxkatz.me>
## What's Changed * fix(mobile): support dragged images in the composer by @t3dotgg in pingdotgg/t3code#4953 * fix(mobile): stop long iOS threads from jumping while scrolling up by @t3dotgg in pingdotgg/t3code#4867 * fix(web): keep worktree default when switching a draft's machine by @t3dotgg in pingdotgg/t3code#4964 * perf(mobile): reconnect environments immediately on resume by @t3dotgg in pingdotgg/t3code#4878 * feat(web): pasting a huge screenshot now compresses it instead of erroring by @t3dotgg in pingdotgg/t3code#4967 * feat(web): regenerate thread titles from sidebar by @t3dotgg in pingdotgg/t3code#4810 * fix(web): show server update progress through reconnect by @t3dotgg in pingdotgg/t3code#4903 * feat(search): find threads by conversation content by @t3dotgg in pingdotgg/t3code#4959 * fix: marketing site Vercel builds no longer die after ~100 deploys by @t3dotgg in pingdotgg/t3code#4975 **Full Changelog**: pingdotgg/t3code@v0.0.32-nightly.20260730.955...v0.0.32-nightly.20260730.956 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.32-nightly.20260730.956
Problem
Opening a new thread (CMD+SHIFT+O) and then switching the target machine in the composer reset the workspace selector to "Current checkout" — even with
defaultThreadEnvMode: "worktree"configured. The branch shown was whatever stale branch the target machine's main clone happened to have checked out.Cause
Changing the environment on a draft goes through the
projectChangedpath incomposerDraftStore(bothcreateDraftThreadStateandsetDraftThreadContext). That path cleared branch and worktree path — correct, they're machine-specific — but also hardcodedenvModeto"local"andstartFromOrigintofalse, discarding the user's configured default.Fix
On a project/environment change, still reset branch and worktree path, but carry env mode and start-from-origin — they're user intent, not machine state. Updated the two store tests that asserted the old reset behavior.
🤖 Generated with Claude Code (Claude Fable 5)
Note
Low Risk
Localized composer draft state logic with updated unit tests; no auth, persistence schema, or server behavior changes.
Overview
Fixes new-thread drafts snapping back to Current checkout when you change the target machine in the composer, even with
defaultThreadEnvMode: "worktree".composerDraftStorestill clears branch and worktree path on project/environment changes (they are machine-specific), but now preservesenvModeandstartFromOrigininstead of forcinglocalandfalse. The same rule applies increateDraftThreadStateandsetDraftThreadContext.useHandleNewThreadcomment updated to match.Tests now expect worktree mode and start-from-origin to survive remapping a draft to another environment.
Reviewed by Cursor Bugbot for commit 63ce619. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Keep worktree
envModewhen switching a draft thread's machinePreviously, changing a draft thread's project or environment forced
envModeto"local"and resetstartFromOrigintofalse. Now both fields are carried forward from the existing thread state unless explicitly overridden. Branch and worktree path are still cleared on project/environment change.The fix applies to both
createDraftThreadStateand thesetDraftThreadContextin-place update path.Macroscope summarized 63ce619.