Skip to content

fix(web): keep model picker shortcuts in sync - #5400

Merged
t3dotgg merged 1 commit into
mainfrom
t3code/fix-codex-favorite-shortcut
Aug 5, 2026
Merged

fix(web): keep model picker shortcuts in sync#5400
t3dotgg merged 1 commit into
mainfrom
t3code/fix-codex-favorite-shortcut

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Aug 5, 2026

Copy link
Copy Markdown
Member

The model picker could keep a model’s positional shortcut from Favorites after switching to a provider-specific menu. The displayed hint then disagreed with the current menu and could duplicate another shortcut.

The virtualized list now redraws rows when either favorite state or the current menu’s shortcut labels change, keeping the visible hints aligned with keyboard selection.

Tests: web typecheck; targeted format and lint; 45 focused model-ordering and keybinding tests.

Made by GPT-5.6 Sol via the Codex harness in T3 Code.


Note

Low Risk
Small UI-only change to virtualized list invalidation in the model picker; no auth, data, or API impact.

Overview
Fixes stale positional shortcut hints in the model picker when switching between Favorites and a provider-specific sidebar view.

The virtualized LegendList only passed favoritesSet as extraData, so recycled rows did not redraw when menu-specific jump labels (modelJumpLabelByKey) changed. extraData is now a memoized { favoritesSet, modelJumpLabelByKey } object so list rows refresh when either favorites or the current menu’s shortcut mapping updates.

Reviewed by Cursor Bugbot for commit 29be195. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix model picker shortcuts staying in sync with LegendList renders

The LegendList in ModelPickerContent.tsx previously only received favoritesSet as extraData, so shortcut labels (modelJumpLabelByKey) were not triggering re-renders when updated. Both values are now bundled into a memoized modelListExtraData object passed as extraData, keeping shortcut labels in sync with list item rendering.

Macroscope summarized 29be195.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 49065b71-c81d-4741-b320-de8fb759043c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 5, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 29be195

Simple bug fix that adds modelJumpLabelByKey to the list's extraData prop so the component properly re-renders when keyboard shortcuts change. Small scope, proper memoization, and clear intent.

You can customize Macroscope's approvability policy. Learn more.

@t3dotgg
t3dotgg merged commit 37d3667 into main Aug 5, 2026
17 checks passed
@t3dotgg
t3dotgg deleted the t3code/fix-codex-favorite-shortcut branch August 5, 2026 11:23
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 5, 2026
## What's Changed
* fix(web): keep model picker shortcuts in sync by @t3dotgg in pingdotgg/t3code#5400
* fix(web): keep terminal font settings reliable by @StiensWout in pingdotgg/t3code#5397


**Full Changelog**: pingdotgg/t3code@v0.0.32-nightly.20260805.1005...v0.0.32-nightly.20260805.1006

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.32-nightly.20260805.1006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant