fix(web): keep model picker shortcuts in sync - #5400
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 29be195 Simple bug fix that adds You can customize Macroscope's approvability policy. Learn more. |
## What's Changed * fix(web): keep model picker shortcuts in sync by @t3dotgg in pingdotgg/t3code#5400 * fix(web): keep terminal font settings reliable by @StiensWout in pingdotgg/t3code#5397 **Full Changelog**: pingdotgg/t3code@v0.0.32-nightly.20260805.1005...v0.0.32-nightly.20260805.1006 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.32-nightly.20260805.1006
The model picker could keep a model’s positional shortcut from Favorites after switching to a provider-specific menu. The displayed hint then disagreed with the current menu and could duplicate another shortcut.
The virtualized list now redraws rows when either favorite state or the current menu’s shortcut labels change, keeping the visible hints aligned with keyboard selection.
Tests: web typecheck; targeted format and lint; 45 focused model-ordering and keybinding tests.
Made by GPT-5.6 Sol via the Codex harness in T3 Code.
Note
Low Risk
Small UI-only change to virtualized list invalidation in the model picker; no auth, data, or API impact.
Overview
Fixes stale positional shortcut hints in the model picker when switching between Favorites and a provider-specific sidebar view.
The virtualized
LegendListonly passedfavoritesSetasextraData, so recycled rows did not redraw when menu-specific jump labels (modelJumpLabelByKey) changed.extraDatais now a memoized{ favoritesSet, modelJumpLabelByKey }object so list rows refresh when either favorites or the current menu’s shortcut mapping updates.Reviewed by Cursor Bugbot for commit 29be195. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix model picker shortcuts staying in sync with
LegendListrendersThe
LegendListin ModelPickerContent.tsx previously only receivedfavoritesSetasextraData, so shortcut labels (modelJumpLabelByKey) were not triggering re-renders when updated. Both values are now bundled into a memoizedmodelListExtraDataobject passed asextraData, keeping shortcut labels in sync with list item rendering.Macroscope summarized 29be195.