fix(web): preserve terminal font size when splitting - #5444
Merged
Conversation
Contributor
ApprovabilityVerdict: Needs human review This PR removes the automatic font-size fitting feature, which is a user-facing behavior change: splitting terminals will no longer auto-shrink font size to fit 80 columns. While the code change is a clean removal, reverting recently-added user-visible behavior warrants human confirmation. You can customize Macroscope's approvability policy. Learn more. |
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Aug 5, 2026
## What's Changed * fix(web): preserve terminal font size when splitting by @t3-code[bot] in pingdotgg/t3code#5444 * Prevent terminal loading flash by @juliusmarminge in pingdotgg/t3code#5432 **Full Changelog**: pingdotgg/t3code@v0.0.32-nightly.20260805.1008...v0.0.32-nightly.20260805.1009 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.32-nightly.20260805.1009
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Why
splitting a terminal narrowed each pane and caused
fit()to nearly halve the configured font size. pane width should affect the grid dimensions, not override the user's appearance setting.UI Changes
before
after
Checklist
Testing
pnpm exec vp run --filter @t3tools/web typecheckpnpm --filter @t3tools/web test -- src/terminal/ghostty/surface.test.ts(207 files, 1,806 tests)pnpm exec vp fmt --check apps/web/src/terminal/ghostty/surface.ts apps/web/src/terminal/ghostty/surface.test.tsBuilt with OpenAI GPT-5.4 via T3bot.
Note
Preserve terminal font size when splitting by removing auto-fit font size reduction in
GhosttyTerminalSurfacePreviously,
fit()would reduce the font size viafittedTerminalFontSizeto ensure at least 80 columns fit within the mount width, which caused the font size to shrink when splitting the terminal. Now,fit()only adjusts canvas dimensions and grid layout without modifying the font size. ThefittedTerminalFontSizeutility, its constants, and related tests are removed entirely.Macroscope summarized cab920b.
Note
Low Risk
Terminal rendering and resize behavior only; no auth, data, or API surface changes.
Overview
Split terminals no longer shrink glyphs when a pane gets narrower. The web Ghostty surface used to run an 80-column heuristic in
fit()that lowered the rendered font size until the grid fit the canvas width, which made split panes look half-sized compared to the user’s setting.This change drops
fittedTerminalFontSize, therequestedFontSizetracking, and the related unit tests. Resize now only updates column/row counts from the mount size and fixed metrics; configured font size is unchanged onsetFontand on layout reflow.Reviewed by Cursor Bugbot for commit cab920b. Bugbot is set up for automated code reviews on this repo. Configure here.