fix(web): show Stop button while input is pending - #5554
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 1365636 This is a focused UI bug fix that shows the Stop generation button when input is pending and the system is running. The change refactors existing button code into a helper and adds conditional rendering, with comprehensive test coverage. Low-risk, self-contained change. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 1365636
## What's Changed * chore(ci): vouch StiensWout by @t3-code[bot] in pingdotgg/t3code#5637 * feat(desktop): remember recently used sites in the Browser panel by @chrisdeeming in pingdotgg/t3code#5270 * chore: vouch chrisdeeming by @t3-code[bot] in pingdotgg/t3code#5641 * feat(web): make sidebar artwork theme-aware by @maria-rcks in pingdotgg/t3code#5636 * fix(web): reconnect the composer seam for remote non-Git projects by @caezium in pingdotgg/t3code#5633 * fix(web): show Stop button while input is pending by @ipanasenko in pingdotgg/t3code#5554 * feat(web): fold plan mode and token-by-token output into Legacy features by @t3dotgg in pingdotgg/t3code#5664 ## New Contributors * @chrisdeeming made their first contribution in pingdotgg/t3code#5270 **Full Changelog**: pingdotgg/t3code@v0.0.33-nightly.20260807.1026...v0.0.33-nightly.20260808.1029 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.33-nightly.20260808.1029
A running turn that asks for user input replaces the normal composer actions, which hides the Stop control even though settling instructs the user to interrupt first:
Bringing the Stop button back:
Mobile app already shows Stop button in this case:
Reuse the existing Stop generation control beside the pending question actions while the turn is running. Size it to match the adjacent small action on desktop while preserving the existing standalone Stop size. Add focused render coverage for visibility and both size contexts.
Model: GPT-5.6 Sol
Harness: Codex in T3 Code
Note
Show Stop generation button in composer when input is pending and turn is running
Previously, the Stop generation button was only shown in the standalone (no pending action) state. Now, when a pending action is present and
isRunningis true, the Stop button also appears alongside the pending action controls.renderStopGenerationButtonhelper in ComposerPrimaryActions.tsx that renders two size variants: smaller (size-8 sm:size-7) inside pending actions and larger (size-8 sm:h-8 sm:w-8) standalone.isRunningis true, which is a new UI state.Macroscope summarized 1365636.
Note
Low Risk
UI-only composer action visibility and sizing with no auth, data, or API changes; behavior is covered by focused tests.
Overview
Stop generation is available again when a turn is still running but the composer is showing pending question actions (Next/Submit), matching mobile behavior and guidance to interrupt before settling.
ComposerPrimaryActionspulls the stop control intorenderStopGenerationButton, renders it beside pending actions whenisRunning, and usessm:size-7there so it lines up with adjacent small buttons while the standalone stop keepssm:h-8 sm:w-8.Tests use static markup to assert stop visibility with/without a running turn and the two size class paths.
Reviewed by Cursor Bugbot for commit 1365636. Bugbot is set up for automated code reviews on this repo. Configure here.