Skip to content

fix(web): show Stop button while input is pending - #5554

Merged
maria-rcks merged 3 commits into
pingdotgg:mainfrom
ipanasenko:fix/pending-user-input-stop
Aug 7, 2026
Merged

fix(web): show Stop button while input is pending#5554
maria-rcks merged 3 commits into
pingdotgg:mainfrom
ipanasenko:fix/pending-user-input-stop

Conversation

@ipanasenko

@ipanasenko ipanasenko commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

A running turn that asks for user input replaces the normal composer actions, which hides the Stop control even though settling instructs the user to interrupt first:

image

Bringing the Stop button back:

image

Mobile app already shows Stop button in this case:

image

Reuse the existing Stop generation control beside the pending question actions while the turn is running. Size it to match the adjacent small action on desktop while preserving the existing standalone Stop size. Add focused render coverage for visibility and both size contexts.

Model: GPT-5.6 Sol
Harness: Codex in T3 Code

Note

Show Stop generation button in composer when input is pending and turn is running

Previously, the Stop generation button was only shown in the standalone (no pending action) state. Now, when a pending action is present and isRunning is true, the Stop button also appears alongside the pending action controls.

  • Extracts a renderStopGenerationButton helper in ComposerPrimaryActions.tsx that renders two size variants: smaller (size-8 sm:size-7) inside pending actions and larger (size-8 sm:h-8 sm:w-8) standalone.
  • Adds tests in ComposerPrimaryActions.test.ts covering Stop button visibility under running/non-running states and size class differences.
  • Behavioral Change: the Stop button now renders in the pending action branch when isRunning is true, which is a new UI state.

Macroscope summarized 1365636.


Note

Low Risk
UI-only composer action visibility and sizing with no auth, data, or API changes; behavior is covered by focused tests.

Overview
Stop generation is available again when a turn is still running but the composer is showing pending question actions (Next/Submit), matching mobile behavior and guidance to interrupt before settling.

ComposerPrimaryActions pulls the stop control into renderStopGenerationButton, renders it beside pending actions when isRunning, and uses sm:size-7 there so it lines up with adjacent small buttons while the standalone stop keeps sm:h-8 sm:w-8.

Tests use static markup to assert stop visibility with/without a running turn and the two size class paths.

Reviewed by Cursor Bugbot for commit 1365636. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d1a73554-37a2-4833-9800-ba8dc137152b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 6, 2026
@ipanasenko ipanasenko changed the title fix(web): show stop while input is pending fix(web): show Stop button while input is pending Aug 6, 2026
@ipanasenko
ipanasenko marked this pull request as ready for review August 6, 2026 23:34
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 6, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 1365636

This is a focused UI bug fix that shows the Stop generation button when input is pending and the system is running. The change refactors existing button code into a helper and adds conditional rendering, with comprehensive test coverage. Low-risk, self-contained change.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp
macroscopeapp Bot dismissed their stale review August 7, 2026 09:22

Dismissing prior approval to re-evaluate 1365636

@maria-rcks
maria-rcks merged commit 45d9aa9 into pingdotgg:main Aug 7, 2026
17 checks passed
@ipanasenko
ipanasenko deleted the fix/pending-user-input-stop branch August 7, 2026 21:04
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 8, 2026
## What's Changed
* chore(ci): vouch StiensWout by @t3-code[bot] in pingdotgg/t3code#5637
* feat(desktop): remember recently used sites in the Browser panel by @chrisdeeming in pingdotgg/t3code#5270
* chore: vouch chrisdeeming by @t3-code[bot] in pingdotgg/t3code#5641
* feat(web): make sidebar artwork theme-aware by @maria-rcks in pingdotgg/t3code#5636
* fix(web): reconnect the composer seam for remote non-Git projects by @caezium in pingdotgg/t3code#5633
* fix(web): show Stop button while input is pending by @ipanasenko in pingdotgg/t3code#5554
* feat(web): fold plan mode and token-by-token output into Legacy features by @t3dotgg in pingdotgg/t3code#5664

## New Contributors
* @chrisdeeming made their first contribution in pingdotgg/t3code#5270

**Full Changelog**: pingdotgg/t3code@v0.0.33-nightly.20260807.1026...v0.0.33-nightly.20260808.1029

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.33-nightly.20260808.1029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants