fix(server): stop showing commit/push/PR notices as errors in the work log - #5559
Conversation
…ed as error rows Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved d6aa52d Simple bug fix extending an existing message filter to suppress two additional informational message types from appearing as errors. The change is minimal, well-tested, and the intent is clear from both the PR title and code comments. You can customize Macroscope's approvability policy. Learn more. |
## What's Changed * fix(server): skip origin fetch when creating worktrees in repos without an origin remote by @t3dotgg in pingdotgg/t3code#5556 * fix(web): update tooltip no longer dismisses when scrolling release notes by @t3dotgg in pingdotgg/t3code#5547 * fix(server): stop showing commit/push/PR notices as errors in the work log by @t3dotgg in pingdotgg/t3code#5559 * fix(web): show remote environment for non-Git projects by @t3dotgg in pingdotgg/t3code#5555 * fix(server): stopping a Claude thread no longer shows an ede_diagnostic error by @t3dotgg in pingdotgg/t3code#5557 * fix(web): show one toast when snoozing threads in bulk by @t3dotgg in pingdotgg/t3code#5560 **Full Changelog**: pingdotgg/t3code@v0.0.32-nightly.20260806.1018...v0.0.32-nightly.20260807.1019 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.32-nightly.20260807.1019
Newer Claude Code builds emit two undeclared system message subtypes —
vcs_state_changed(fires on commit/push/rebase) andcode_change_published(fires when a PR is opened). They aren't in the SDK's typed union yet, so the ClaudeAdapter's unknown-subtype fallback turned every one of them into aruntime.warning, which the work log renders as a red ✗ error row. On this machine alone the logs show 100+ of these fake errors, one for nearly every commit, push, and PR an agent makes.These are purely informational notices and the work log already shows the underlying
git/ghtool calls, so they're now consumed silently alongsidebackground_tasks_changedin the existing undeclared-wire-subtype guard. Added both to the no-warning-rows adapter test.Change made by Claude Fable 5 via Claude Code.
🤖 Generated with Claude Code
Note
Low Risk
Narrow adapter change that only suppresses display of two informational SDK subtypes; no auth, data, or API behavior changes.
Overview
Stops commit/push/PR CLI notices from showing as red error rows in the work log when newer Claude Code builds emit undeclared
systemsubtypes that are not in the SDK union.ClaudeAdapterextends the existing undeclared-wire-subtype guard (alongsidebackground_tasks_changed) to return early forvcs_state_changedandcode_change_publishedinstead of hitting the unknown-subtype path that emitsruntime.warning. Those messages are informational only; git/gh tool activity is already represented elsewhere.Tests add sample payloads for both subtypes to the adapter case that asserts silent consumption with no spurious warning rows.
Reviewed by Cursor Bugbot for commit d6aa52d. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Suppress
vcs_state_changedandcode_change_publishedsystem messages from the work logIn ClaudeAdapter.ts, a single early-return for
background_tasks_changedis replaced with a switch statement that also silently consumesvcs_state_changedandcode_change_publishedsubtypes. This prevents commit, push, and PR notifications from surfacing as errors in the work log.Macroscope summarized d6aa52d.