Skip to content

fix(web): inherit terminal size in simple typography - #5628

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
chrisdeeming:fix/web-terminal-font-size-inheritance
Aug 8, 2026
Merged

fix(web): inherit terminal size in simple typography#5628
maria-rcks merged 1 commit into
pingdotgg:mainfrom
chrisdeeming:fix/web-terminal-font-size-inheritance

Conversation

@chrisdeeming

@chrisdeeming chrisdeeming commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

What Changed

In basic typography mode, the terminal now inherits the monospace font size, matching its existing font-family behavior. Advanced mode keeps its separate terminal size.

Why

The Monospace font setting says it covers the terminal, but only the family changed it. The size continued using the hidden Advanced value.

UI Changes

Before After
Terminal remains small at 18 px Terminal follows the 18 px monospace size
terminal-font-size-before terminal-font-size-after

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes — not applicable

Note

Inherit code font size for terminal in simple typography mode

In simple typography mode, the terminal now uses the code font size instead of its own independent font size setting. This applies to both the terminal viewport in ThreadTerminalDrawer and the terminal preview in the simple settings panel. A new resolveTerminalFontSizePreference utility in appearanceFonts.ts centralizes this logic, returning the terminal font size only when advanced typography is enabled.

Macroscope summarized 9d22990.


Note

Low Risk
Small, localized appearance logic with tests; no auth, data, or API changes.

Overview
Simple typography now applies the code (monospace) font size to the terminal, matching how terminal font family already follows code in that mode. Advanced typography still uses the dedicated terminal size.

A new resolveTerminalFontSizePreference helper in appearanceFonts.ts mirrors resolveTerminalFontPreference. It is wired into the thread terminal drawer and the simple-settings TerminalFontPreview, with unit tests for both modes.

Reviewed by Cursor Bugbot for commit 9d22990. Bugbot is set up for automated code reviews on this repo. Configure here.

@chrisdeeming
chrisdeeming marked this pull request as draft August 7, 2026 16:25
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 7, 2026
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 393785d8-5c9e-4a92-a9be-8cfe53db8a10

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 7, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 7710331

This is a simple, self-contained bug fix that adds font size inheritance for terminals in simple typography mode, mirroring the existing font family inheritance pattern. The new function follows an established pattern, includes tests, and affects only UI appearance settings.

You can customize Macroscope's approvability policy. Learn more.

@chrisdeeming
chrisdeeming marked this pull request as ready for review August 7, 2026 16:32
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 7, 2026 16:32

Dismissing prior approval to re-evaluate 7710331

@chrisdeeming
chrisdeeming force-pushed the fix/web-terminal-font-size-inheritance branch from 7710331 to 9d22990 Compare August 8, 2026 01:38
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. and removed vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 8, 2026
@maria-rcks
maria-rcks merged commit daf8ee0 into pingdotgg:main Aug 8, 2026
15 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 8, 2026
## What's Changed
* feat: sidebar v2 is now the default sidebar by @t3dotgg in pingdotgg/t3code#5672
* fix(server): stop PR status lookups amplifying GitHub rate limits by @t3dotgg in pingdotgg/t3code#5673
* fix(web): delay transient reconnect warnings by @t3-code[bot] in pingdotgg/t3code#5670
* fix(web): inherit terminal size in simple typography by @chrisdeeming in pingdotgg/t3code#5628


**Full Changelog**: pingdotgg/t3code@v0.0.33-nightly.20260808.1029...v0.0.33-nightly.20260808.1030

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.33-nightly.20260808.1030
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Aug 8, 2026
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Aug 8, 2026
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Aug 8, 2026
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Aug 8, 2026
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Aug 8, 2026
cursor Bot pushed a commit to aaditagrawal/t3code that referenced this pull request Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants