fix(mobile): long-pressing a thread row no longer navigates into the thread

[juliusmarminge]

Fixes the bug phil5034 reported on Discord: long-pressing a thread row in the overview to open the context menu could also navigate into the thread. Long press now only opens the menu; taps still navigate.

Why it happened

Two stacked issues, both iOS-only in our setup (Android already injects a guard):

1. A Pressable with only onPress fires on finger-up after any hold duration. The thread-row pressables have no onLongPress on iOS, so a long press released just under the ~500 ms native context-menu threshold read as a tap and navigated. Same class of bug as react-native-context-menu-view#60.

2. The real double-fire: RN's Fabric touch handler is never cancelled when the menu opens. Our @react-native-menu/menu patch makes the native button touch-transparent (so row taps reach the Pressable) and hosts the UIContextMenuInteraction on the host component view — i.e. inside the RN view tree. RCTSurfaceTouchHandler.canBePreventedByGestureRecognizer: returns NO for any recognizer attached inside the RN hierarchy, and cancelsTouchesInView only cancels view-level delivery, not un-prevented gesture recognizers. So RN kept tracking the touch after the menu appeared; on finger-up Pressability fired onPress and navigated with the menu already showing. Documented ecosystem-wide in zeego#145.

The fix

Mirror the Android branch of ControlPillMenu on iOS: in shouldOpenOnLongPress mode, clone the child with a no-op onLongPress and delayLongPress: 350 (below the ~500 ms menu threshold). Once onLongPress dispatches, Pressability suppresses onPress on release (isPressCanceledByLongPress), which closes both holes — short taps still navigate, holds past 350 ms can only open the menu. A child's own onLongPress/delayLongPress are preserved if ever passed. Covers all four long-press menu call sites (v1 + v2 thread rows, both pending-task rows), which all pass a Pressable as the direct child.

Verification

Verified in the dev client on an iPhone 17 Pro simulator against a seeded showcase environment, driving real touch events:

• 1.2 s long press → context menu (Settle/Snooze/Pin/Delete) opens, dismissing it lands back on the overview, no navigation
• 0.6 s press (releasing right at the menu threshold — the raciest timing and the reported repro) → menu only, no navigation
• Normal tap → still navigates into the thread

Typecheck and lint pass.

🤖 Generated with Claude Code

---

Note

Low Risk
Small, localized touch-handling change on iOS menu wrappers; behavior aligns with the existing Android branch and only affects long-press menu rows.

Overview
Fixes an iOS-only bug where long-pressing a thread row to open the context menu could also fire the row’s onPress and navigate into the thread.

ControlPillMenu (iOS) now mirrors the existing Android long-press path: when shouldOpenOnLongPress is set, it clones the direct child Pressable with a no-op onLongPress and delayLongPress: 350 (under the ~500ms native menu threshold). That lets React Native’s Pressability cancel onPress on finger-up after a hold, so opens the menu without tap-through. Short taps still navigate; existing child onLongPress / delayLongPress props are left unchanged if present.

Applies to all long-press menu usages (v1/v2 thread rows and pending-task rows) without changing those call sites.

^{Reviewed by Cursor Bugbot for commit 7ad735a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix long-press on thread rows to prevent navigation on iOS

In ControlPill.tsx, when shouldOpenOnLongPress is enabled on iOS, the wrapped child is cloned to inject a no-op onLongPress handler and a 350ms delayLongPress if neither is already set. This prevents the child's tap/navigation from firing after a long-press that opens the menu.

^{Macroscope summarized 7ad735a.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d719e3ab-5f8e-4a5e-a5e5-4e0e26d8bec3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	11.3 KiB	11.3 KiB	+10 B (+0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	5.5 KiB	5.5 KiB	−2 B (−0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	5.9 KiB	5.9 KiB	+12 B (+0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	49.7 KiB	49.7 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	16	16	0 (0.0%)	21	✅
Claude	Total thread wire	11.3 KiB	11.3 KiB	+6 B (+0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	5.5 KiB	5.5 KiB	−2 B (−0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	5.9 KiB	5.9 KiB	+8 B (+0.1%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	50.6 KiB	50.6 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	16	16	0 (0.0%)	21	✅

Baseline: 83d769f · PR result: 7ad735a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 94.6 KiB
• Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved 7ad735a

Straightforward bug fix for a mobile touch interaction issue. The change is self-contained in ControlPillMenu, only affects long-press behavior, and preserves existing handlers. Well-commented and authored by the file's primary maintainer.

^{You can customize Macroscope's approvability policy. Learn more.}