fix(mobile): stabilize thread composer and interactions

[juliusmarminge]

What changed

• Keep the floating composer anchored after keyboard dismissal on iOS and Android.
• Stop live-feed updates from pulling users back to the end while they are reading history.
• Add a floating scroll-to-end control that uses the same keyboard-aware LegendList path.
• Bound long pending-input forms to the viewport, keep their actions reachable, and preserve multi-select answers.
• Add focused tests for live-follow, pending-input layout, and answer shaping.

This consolidates #5118 and #5915 into #5986 as the single branch to test and merge. Their original commit authorship is preserved.

Closes #5434.

Why

Several mobile thread interactions shared the same keyboard, overlay, and end-follow boundaries. Testing them together catches the real integration behavior: the composer stays attached to the keyboard, user-driven scrolling remains respected, the return-to-end affordance reflects that same state, and pending input remains usable in the remaining viewport.

Validation

• vp test run apps/mobile/src/features/threads/thread-feed-live-follow.test.ts apps/mobile/src/features/threads/pendingUserInputLayout.test.ts apps/mobile/src/lib/threadActivity.test.ts — 24 tests passed.
• vp run --filter @t3tools/mobile typecheck passed.
• Targeted vp lint --report-unused-disable-directives passed for all changed TypeScript files.
• node scripts/mobile-native-static-check.ts passed SwiftLint, ktlint, and detekt.
• vp fmt --check passed for all changed files.
• React Doctor scoped to the diff scored 88/100; the four remaining findings are non-blocking heuristics for the intentionally bounded question scroller, existing screen size, thread-switch reset, and a tiny normalization pass.

UI evidence

Pending input: before, after, and scroll video.

Scroll-to-end: Android interaction video.

Manual test plan

1. Open and dismiss the keyboard repeatedly; confirm the composer returns to the bottom.
2. Scroll upward while an agent is streaming; confirm new activity does not interrupt reading.
3. Tap the down-arrow during and after momentum; confirm the thread returns to the end and the button disappears.
4. Exercise a long pending-input request with single- and multi-select questions while the keyboard is open and closed.
5. Repeat the keyboard and scrolling cases on both iOS and Android.

Model: GPT-5. Harness: Codex.

Note

Stabilize mobile thread composer, questionnaire card, and settings navigation

• Rewrites PendingUserInputCard as a collapsible bar/overlay card with animated expand/collapse, scroll support, multi-select answers, and a Stop control; the composer is hidden (not unmounted) while a user-input request is active
• Refactors ThreadFeed end-follow logic using a new resolveThreadFeedLiveFollow state machine that respects user scroll sessions and native momentum, and surfaces a floating scroll-to-end button in ThreadDetailScreen
• Adds a native iOS context menu to ThreadComposer for model/option/runtime selection with haptic feedback, keeping the keyboard visible during changes
• Restructures settings navigation into a nested SettingsContentStack inside SettingsSheetStack, fixing header transition artifacts on iOS 26 and removing the ClerkSettingsSheetDetentProvider
• Patches @react-native-menu/menu to support in-place menu updates, nested submenus, subtitles, and keepsMenuPresented; patches @clerk/expo to prefer native UINavigationController pop on back; patches react-native-screens to avoid rebuilding header bar button items when config is unchanged
• Risk: onChangePendingUserInputAnswer now receives a full UserInputQuestion object instead of a questionId string, and onSelectUserInputOption callers must pass the full question; multi-select answers are now string[] instead of string

^{Macroscope summarized faa634c.}

---

Note

Medium Risk
Large touch surface across navigation, keyboard, list insets, and vendored patches; behavior is heavily platform-specific though covered by new unit tests.

Overview
This PR tightens mobile thread UX (composer, feed follow, pending input) and settings / auth navigation, with supporting native patches and dependency bumps.

Thread detail: Live-follow now uses resolveThreadFeedLiveFollow so streaming no longer yanks readers off history unless they return to the true end; a floating scroll-to-end control appears when follow is off. KeyboardStickyView only tracks the keyboard while it is visible so the composer does not stick mid-screen after dismiss. Pending user input becomes a collapsible bar that expands over the feed with animated bottom inset; the composer stays mounted but hidden, multi-select answers are supported, and option selection passes the full UserInputQuestion. On iOS, thread settings can change via a native ControlPillMenu without losing keyboard focus.

Settings: Settings routes nest under SettingsContent inside a headerless outer sheet stack; ClerkSettingsSheetDetent is removed. Clerk auth/profile back can pop natively (Clerk Expo patch). OTA update checks skip Metro/dev via isAppUpdateCheckAvailable.

Infrastructure: @legendapp/list 3.3.5 with keyboard/inset patches, @react-native-menu/menu patches for deeper menus and keepsMenuPresented, plus focused unit tests for live-follow, pending-input layout, and answer shaping.

^{Reviewed by Cursor Bugbot for commit faa634c. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 35cafe2b-6db5-4c80-b383-3e1ee88210cf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	11.3 KiB	11.3 KiB	0 B (0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	5.5 KiB	5.5 KiB	−3 B (−0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	5.9 KiB	5.9 KiB	+3 B (+0.1%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	49.7 KiB	49.7 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	16	16	0 (0.0%)	21	✅
Claude	Total thread wire	11.3 KiB	11.3 KiB	+3 B (+0.0%)	15.1 KiB	✅
Claude	Thread snapshot wire	5.5 KiB	5.5 KiB	−1 B (−0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	5.9 KiB	5.9 KiB	+4 B (+0.1%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	50.6 KiB	50.6 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	16	16	0 (0.0%)	21	✅

Baseline: b91a000 · PR result: faa634c · Source CI: failure

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 94.6 KiB
• Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Needs human review

6 blocking correctness issues found. This PR introduces significant new mobile UI capabilities (collapsible questionnaire, native settings menu, scroll-to-end button) and refactors core scroll/navigation behavior rather than being a simple stabilization fix. Multiple high-severity findings remain open regarding viewport layout edge cases, native bar button caching issues, and scroll state synchronization.

^{You can customize Macroscope's approvability policy. Learn more.}

[macroscopeapp]

🟠 High threads/ThreadDetailScreen.tsx:229

derivePendingUserInputMaxHeight clamps the computed available height to a 160px minimum, so on a short or landscape phone with the keyboard open, the card can be 160px tall even when the true available space is far smaller (or negative). Because the card is inside a bottom-anchored overlay that is not itself scrollable, the top of the form is pushed off-screen and its initial questions are unreachable. Additionally, when both activePendingApproval and activePendingUserInput are non-null, the max-height calculation does not subtract the simultaneously rendered PendingApprovalCard, so the overlay holds both cards plus its gap and overflows the viewport, pushing controls or the composer off-screen. Consider allowing the card to shrink below 160px when space is constrained, and subtract the approval card's height from the available space when both are present.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @apps/mobile/src/features/threads/ThreadDetailScreen.tsx around line 229:

`derivePendingUserInputMaxHeight` clamps the computed available height to a 160px minimum, so on a short or landscape phone with the keyboard open, the card can be 160px tall even when the true available space is far smaller (or negative). Because the card is inside a bottom-anchored overlay that is not itself scrollable, the top of the form is pushed off-screen and its initial questions are unreachable. Additionally, when both `activePendingApproval` and `activePendingUserInput` are non-null, the max-height calculation does not subtract the simultaneously rendered `PendingApprovalCard`, so the overlay holds both cards plus its gap and overflows the viewport, pushing controls or the composer off-screen. Consider allowing the card to shrink below 160px when space is constrained, and subtract the approval card's height from the available space when both are present.

[macroscopeapp]

🟠 High

t3code/apps/mobile/src/features/threads/ThreadDetailScreen.tsx

Line 402 in 1092d7e

key={props.selectedThread.id}

When switching to a thread in a different environment that happens to share the same ThreadId, ThreadFeed is not remounted (it is keyed by threadId alone), so its internal endFollowEnabled latch keeps its previous value. Meanwhile this effect unconditionally sets the parent endFollowEnabled back to true, hiding the scroll-to-end button. The result is that the feed can remain in an unfollowed state with no visible control to return to the end. Consider keying ThreadFeed by scopedThreadKey (or resetting the latch via the existing onEndFollowEnabledChange callback) so the child latch and parent state stay in sync across environment switches.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @apps/mobile/src/features/threads/ThreadDetailScreen.tsx around line 402:

When switching to a thread in a different environment that happens to share the same `ThreadId`, `ThreadFeed` is not remounted (it is keyed by `threadId` alone), so its internal `endFollowEnabled` latch keeps its previous value. Meanwhile this effect unconditionally sets the parent `endFollowEnabled` back to `true`, hiding the scroll-to-end button. The result is that the feed can remain in an unfollowed state with no visible control to return to the end. Consider keying `ThreadFeed` by `scopedThreadKey` (or resetting the latch via the existing `onEndFollowEnabledChange` callback) so the child latch and parent state stay in sync across environment switches.

[cursor]

Ungated pending-input Stop control

Low Severity

The collapsed pending-input bar shows Stop whenever onStopThread is passed, and ThreadDetailScreen always passes it. ThreadComposer only shows Stop when session status is running or starting, and handleStopThread no-ops otherwise, so this bar can present a control that does nothing.

Additional Locations (1)

• apps/mobile/src/features/threads/ThreadDetailScreen.tsx#L540-L541

 

^{Reviewed by Cursor Bugbot for commit dd0cd4f. Configure here.}

[macroscopeapp]

🟡 Medium threads/ThreadDetailScreen.tsx:356

The inset-correction setTimeout in ThreadDetailScreen checks endFollowEnabledRef.current only when scheduling the timer. If follow is enabled when the questionnaire expands/collapses and the user scrolls up during the 60–220 ms window, ThreadFeed disables follow but the already-scheduled callback still calls scrollMessageToEnd, yanking the user back to the end. Re-check endFollowEnabledRef.current inside the timeout (or cancel the timer when follow is disabled).

Suggested change

	() => {
	void scrollMessageToEnd({ animated: false, closeKeyboard: false }).catch(() => {
	freeze.set(false);
	});
	},
	() => {
	if (!endFollowEnabledRef.current) {
	return;
	}
	void scrollMessageToEnd({ animated: false, closeKeyboard: false }).catch(() => {
	freeze.set(false);
	});
	},

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @apps/mobile/src/features/threads/ThreadDetailScreen.tsx around lines 356-360:

The inset-correction `setTimeout` in `ThreadDetailScreen` checks `endFollowEnabledRef.current` only when scheduling the timer. If follow is enabled when the questionnaire expands/collapses and the user scrolls up during the 60–220 ms window, `ThreadFeed` disables follow but the already-scheduled callback still calls `scrollMessageToEnd`, yanking the user back to the end. Re-check `endFollowEnabledRef.current` inside the timeout (or cancel the timer when follow is disabled).

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{Bugbot Autofix is ON, but a cloud agent failed to start.}

^{Reviewed by Cursor Bugbot for commit faa634c. Configure here.}

[cursor]

Settle scroll ignores follow opt-out

Medium Severity

The pending-input inset settle path gates on endFollowEnabledRef only when scheduling scrollMessageToEnd, not when the timeout fires. endFollowEnabled is also omitted from the effect deps, so a drag that disables follow during the expand/collapse window never cancels the timer. That can yank the feed back to the end after the user has already opted out of live-follow.

Additional Locations (1)

• apps/mobile/src/features/threads/ThreadDetailScreen.tsx#L346-L349

 

^{Reviewed by Cursor Bugbot for commit faa634c. Configure here.}