fix(web): improve built-in theme contrast - #6000
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved e668779 Pure styling/accessibility changes that update color values and CSS classes to meet WCAG AA contrast requirements. No runtime logic is affected - only visual appearance changes to improve readability. You can customize Macroscope's approvability policy. Learn more. |
1f64cb4 to
1ae63c0
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1ae63c0. Configure here.
1ae63c0 to
e668779
Compare
## What's Changed * feat: multi-provider pull requests page with in-app reviews by @Bil0000 in pingdotgg/t3code#4849 * perf(desktop): probe the Windows shell environment concurrently by @tsouth89 in pingdotgg/t3code#5878 * feat(web): add duplicate action to the T3 Code default theme by @UtkarshUsername in pingdotgg/t3code#6013 * fix(web): improve built-in theme contrast by @chrisdeeming in pingdotgg/t3code#6000 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260810.1059...v0.0.34-nightly.20260810.1061 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260810.1061

What Changed
Why
Several built-in theme color pairs fell below the WCAG 2.2 AA requirement of 4.5:1 for normal text.
This raises the audited core palette result from 275/300 to 300/300 passing pairs while retaining the intended visual character of each theme.
UI Changes
Checklist
I included a video for animation/interaction changesNote
Low Risk
Visual-only theme and token changes with no auth, data, or API impact; users may notice slightly different muted text and accent shades across built-in and custom vivid themes.
Overview
Raises built-in and generated theme palettes to WCAG AA (4.5:1) for normal text while keeping each theme’s hue and character.
Palette generation now computes
mutedForegroundandplaceholderfor contrast onmutedandsurfaceRaised, instead of reusingtextMuted. Maintainer themes (T3 Chat light, T3 Code dark, etc.) get tuned accent/action hex values and darker muted/placeholder pairs where needed.CSS and boot wire
--muted-foregroundto--app-theme-muted-foregroundin themed modes, set--ringto--primary, and sync T3 Chat light accent inindex.htmlboot palettes.UI uses
text-update-foregroundfor “new” and update-advisory icons so glyphs stay readable on filled controls. Theme inspector mapsmuted-foregroundutilities to themutedForegroundrole.Tests enforce 4.5:1 on muted/placeholder pairs, message-action hover, and accent pairs (no more 3:1 exception for T3 Chat light).
Reviewed by Cursor Bugbot for commit e668779. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Improve contrast for muted foreground, placeholder, and accent colors in built-in themes
createVividThemeColorsandcreateManagedThemeColorsin themePalette.ts now derivemutedForegroundandplaceholdervia contrast-aware algorithms against their respective surfaces (mutedandsurfaceRaised), replacing the previoustextMutedreuse.accent,update,messageAction,mutedForeground,placeholder, andwarningForeground; T3 Code dark palette primary-related tokens are slightly adjusted.--muted-foregroundin index.css now maps to--app-theme-muted-foregroundinstead of--app-theme-text-mutedin themed dark mode and the sidebar.--ring) now followsvar(--primary)in both light and dark instead of a fixedoklchvalue.NEW_BADGE_CLASSand the version advisory button in settings now usetext-update-foregroundinstead oftext-updatefor legibility.mutedForeground/placeholdercolors compared to previous builds.Macroscope summarized e668779.