Skip to content

fix(desktop): keep release notes visible while downloading - #6412

Open
extoci wants to merge 1 commit into
pingdotgg:mainfrom
extoci:t3code/show-patch-notes-while-downloading
Open

fix(desktop): keep release notes visible while downloading#6412
extoci wants to merge 1 commit into
pingdotgg:mainfrom
extoci:t3code/show-patch-notes-while-downloading

Conversation

@extoci

@extoci extoci commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

What Changed

Keep the desktop update pill's release notes popout hoverable and focusable while an update is downloading. The control retains its disabled styling and ARIA state, and its existing action guard still prevents duplicate downloads.

Why

A native disabled button does not receive the pointer or focus events the tooltip needs, so nightly patch notes disappeared for the duration of a download. Using aria-disabled with explicit disabled styling preserves the non-actionable state without blocking the popout.

UI Changes

Before: The downloading button could not reveal the patch-notes popout.

After: Patch notes remain available while the button shows download progress and stays non-actionable.

Checklist

  • This PR is small and focused
  • I explained what changed and why

Verification

  • vp test run src/components/desktopUpdate.logic.test.ts --project unit
  • vp run typecheck
  • Targeted lint and formatting checks

Built with GPT-5.6-Sol in the Codex harness via T3 Code.


Note

Low Risk
Single UI control change with preserved click guards; no auth, data, or backend impact.

Overview
The sidebar desktop update pill no longer uses the native disabled attribute on its control button. It now drives non-actionable state with aria-disabled, an interactionDisabled flag (existing disabled logic plus pending actions), and explicit opacity/cursor/hover classes so it still looks and behaves disabled.

handleAction still bails when interactions are disabled, so duplicate downloads/installs are not triggered. The change is specifically so hover/focus can reach the button (and the nightly release notes tooltip) while a download is in progress—something a truly disabled button blocks.

Reviewed by Cursor Bugbot for commit 8e3addc. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Keep release notes visible in SidebarUpdateControl while downloading

Removes the native disabled attribute from the update button in SidebarUpdatePill.tsx so the button stays focusable and visible during download. Non-interactive state is now expressed via aria-disabled and conditional Tailwind classes (cursor-not-allowed, opacity-60) rather than the browser's built-in disabled behavior.

Macroscope summarized 8e3addc.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5a5a8d6e-7534-42b7-baf6-1614ad24fa9d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Aug 13, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 8e3addc

This is a targeted UI fix that changes the disabled state implementation from native HTML disabled attribute to CSS-based styling while preserving interaction blocking via JavaScript. The change is self-contained to a single component and the intent (keeping release notes visible during download) is clear and low-risk.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant