fix(mobile): keep sheet actions below status bar - #6635
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d2b517f to
0afca92
Compare
CDVolvik
left a comment
There was a problem hiding this comment.
AndroidSheetHeader was embedded, which forced paddingTop: 8 and put actions under the status bar. Always using Math.max(insets.top, 12) is the right sheet header.
No test. MERGEABLE. I did not open a sheet on a device.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 999a433. Configure here.
ApprovabilityVerdict: Approved 976b1c9 Simple UI fix that swaps You can customize Macroscope's approvability policy. Learn more. |
## What's Changed * fix(mobile): keep sheet actions below status bar by @NitayRabi in pingdotgg/t3code#6635 * fix(web): align Windows update confirmation copy by @StiensWout in pingdotgg/t3code#7208 ## New Contributors * @NitayRabi made their first contribution in pingdotgg/t3code#6635 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260816.1109...v0.0.34-nightly.20260816.1110 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260816.1110

What changed
Android sheet headers now retain the device top safe-area inset, just like full-screen Android headers.
Why
On edge-to-edge Android form sheets, the embedded header used a fixed 8px top padding. On a Pixel 8 Pro this placed the Thread settings confirmation button beneath the system status bar, where it could not be tapped. The shared correction also protects the Git and T3 Connect sheet headers that use the same component.
Fixes #6634.
Validation
vp run --filter @t3tools/mobile typecheckvp lint apps/mobile/src/components/AndroidScreenHeader.tsx --report-unused-disable-directivesgit diff --checkGenerated with GPT-5.6-Sol in the Codex harness via T3 Code.
Note
Replace
AndroidSheetHeaderwithAndroidScreenHeaderin thread settings sheets on AndroidSwaps
AndroidSheetHeaderforAndroidScreenHeaderinThreadSettingsModelsScreenandThreadSettingsChoiceScreenon Android to keep sheet action headers positioned below the status bar. The component props (actions,onBack,title) are unchanged.Macroscope summarized e664a7b.
Note
Low Risk
Android-only header component swap in thread settings sheets; no API or business-logic changes.
Overview
On Android, thread settings form sheets now use
AndroidScreenHeaderinstead ofAndroidSheetHeader, so the header respects the top safe-area inset (not a fixed 8px top padding).That applies to the main Thread settings screen (back + save/done) and nested choice submenus (back + title). Header props are unchanged; only which shared header component is rendered.
Reviewed by Cursor Bugbot for commit e664a7b. Bugbot is set up for automated code reviews on this repo. Configure here.