Skip to content

fix(mobile): keep sheet actions below status bar - #6635

Merged
shivamhwp merged 4 commits into
pingdotgg:mainfrom
NitayRabi:t3code/mobile-modal-confirm-fix
Aug 16, 2026
Merged

fix(mobile): keep sheet actions below status bar#6635
shivamhwp merged 4 commits into
pingdotgg:mainfrom
NitayRabi:t3code/mobile-modal-confirm-fix

Conversation

@NitayRabi

@NitayRabi NitayRabi commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

What changed

Android sheet headers now retain the device top safe-area inset, just like full-screen Android headers.

Why

On edge-to-edge Android form sheets, the embedded header used a fixed 8px top padding. On a Pixel 8 Pro this placed the Thread settings confirmation button beneath the system status bar, where it could not be tapped. The shared correction also protects the Git and T3 Connect sheet headers that use the same component.

Fixes #6634.

Validation

  • vp run --filter @t3tools/mobile typecheck
  • vp lint apps/mobile/src/components/AndroidScreenHeader.tsx --report-unused-disable-directives
  • git diff --check
  • Emulator verification not run because computer-use approval was not provided.

Generated with GPT-5.6-Sol in the Codex harness via T3 Code.

Note

Replace AndroidSheetHeader with AndroidScreenHeader in thread settings sheets on Android

Swaps AndroidSheetHeader for AndroidScreenHeader in ThreadSettingsModelsScreen and ThreadSettingsChoiceScreen on Android to keep sheet action headers positioned below the status bar. The component props (actions, onBack, title) are unchanged.

Macroscope summarized e664a7b.


Note

Low Risk
Android-only header component swap in thread settings sheets; no API or business-logic changes.

Overview
On Android, thread settings form sheets now use AndroidScreenHeader instead of AndroidSheetHeader, so the header respects the top safe-area inset (not a fixed 8px top padding).

That applies to the main Thread settings screen (back + save/done) and nested choice submenus (back + title). Header props are unchanged; only which shared header component is rendered.

Reviewed by Cursor Bugbot for commit e664a7b. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 14, 2026
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ede1da82-8873-40e7-8e2e-0687e1a6a570

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NitayRabi
NitayRabi force-pushed the t3code/mobile-modal-confirm-fix branch from d2b517f to 0afca92 Compare August 14, 2026 19:54

@CDVolvik CDVolvik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AndroidSheetHeader was embedded, which forced paddingTop: 8 and put actions under the status bar. Always using Math.max(insets.top, 12) is the right sheet header.

No test. MERGEABLE. I did not open a sheet on a device.

@NitayRabi
NitayRabi marked this pull request as ready for review August 15, 2026 19:02

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 999a433. Configure here.

Comment thread apps/mobile/src/components/AndroidScreenHeader.tsx Outdated
@macroscopeapp

macroscopeapp Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 976b1c9

Simple UI fix that swaps AndroidSheetHeader for AndroidScreenHeader to respect safe area insets and keep content below the status bar. The change is mechanical with clear intent and no runtime side effects beyond the intended positioning fix.

You can customize Macroscope's approvability policy. Learn more.

@shivamhwp
shivamhwp merged commit 89c52a3 into pingdotgg:main Aug 16, 2026
17 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 16, 2026
## What's Changed
* fix(mobile): keep sheet actions below status bar by @NitayRabi in pingdotgg/t3code#6635
* fix(web): align Windows update confirmation copy by @StiensWout in pingdotgg/t3code#7208

## New Contributors
* @NitayRabi made their first contribution in pingdotgg/t3code#6635

**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260816.1109...v0.0.34-nightly.20260816.1110

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260816.1110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(mobile): keep Android sheet actions below the status bar

3 participants