-
Notifications
You must be signed in to change notification settings - Fork 5.3k
fix(remote): stop button gives immediate feedback and prevents stuck thinking on remote server #8619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ImBIOS
wants to merge
5
commits into
pingdotgg:main
Choose a base branch
from
ImBIOS:fix-remote-stop-no-feedback-stuck-thinking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+665
−30
Open
fix(remote): stop button gives immediate feedback and prevents stuck thinking on remote server #8619
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4871e96
fix(server): strip OSC/ANSI escapes from OpenCode CLI inventory and s…
ImBIOS 30d9c19
merge fix(server): strip OSC/ANSI escapes from OpenCode CLI (fixes #1)
ImBIOS 72a485b
fix(remote): give immediate feedback on Stop and prevent stuck thinki…
ImBIOS 701c881
merge upstream/main into fix-remote-stop
ImBIOS c8b4b3f
fix(remote): stop button gives feedback and releases wedged sessions
ImBIOS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stopping state leaks across threads
Medium Severity
isStoppingThreadis a single boolean, and the reset effect only clears it when the newly selected session is notrunningorstarting. Switching from a stopping thread onto another live thread leaves that thread’s Stop disabled and announced as Stopping.Reviewed by Cursor Bugbot for commit c8b4b3f. Configure here.