fix(05): replace timeout binary with Bash tool native timeout parameter#35
Merged
Merged
Conversation
- Replace 'timeout N cmd' with Bash tool timeout parameter prose - CLI/REST/GraphQL tool commands now use timeout: 10000 (10s) - GraphQL introspection in relearn-tools uses timeout: 15000 (15s) - Error message templates (timed out after 10s) preserved unchanged - Smart-merge gh check in run-tools.md updated to use timeout: 10000
- Replace 'timeout' keyword check with '10000' ms value check in run-tools.md assertion - Replace 'timeout 10' keyword check with '10000' ms value check in begin-the-day assertion - All 287 tests pass
- SUMMARY.md for plan 05-01 - STATE.md updated: phase 5 plan 1 complete, decisions recorded - ROADMAP.md updated: phase 5 progress to 1/1 complete
Contributor
|
Released in v0.10.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 05: fix-the-constant-timeout-warnings
Goal: Remove all
timeout Nbinary invocations from Donna workflow files and replace them with the Bash tool's nativetimeoutparameterStatus: Verified ✓ (4/4 must-haves)
The
timeoutbinary isn't available on macOS without coreutils, causing constant "command not found" warnings when Donna runs. All 5 workflow files now instruct Claude to use the Bash tool's built-intimeoutparameter (in milliseconds) instead — cross-platform, zero external dependencies.Changes
Plan 05-01: Remove timeout binary from workflows
Replaced all
timeout N cmdbinary invocations across 5 workflow files with Bash tool nativetimeoutparameter prose (10000ms/15000ms).Key files modified:
workflows/begin-the-day.md— 3 occurrences (CLI, REST, GraphQL)workflows/run-tools.md— 4 occurrences (CLI, REST, GraphQL, smart-merge gh check)workflows/focus.md— 3 occurrencesworkflows/add-tool.md— 4 auth test referencesworkflows/relearn-tools.md— 2 GraphQL introspection blocks (15000ms)test/stubs.test.cjs— 2 assertions updated to check for10000instead oftimeoutVerification
timeout [0-9]patterns remain in any workflow fileKey Decisions
timeoutparameter (ms) instead of external timeout binary — cross-platform, no coreutils required🤖 Generated with Claude Code