Add SILK fixed-point math primitives#153
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 88.04% 88.19% +0.14%
==========================================
Files 32 34 +2
Lines 7762 7868 +106
==========================================
+ Hits 6834 6939 +105
- Misses 702 703 +1
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JoTurk
reviewed
Jul 17, 2026
| @@ -0,0 +1,2294 @@ | |||
| # Plan: Contribución del Encoder Opus a pion/opus | |||
Member
There was a problem hiding this comment.
Was this file comitted by mistake?
Member
Author
There was a problem hiding this comment.
yeah, my bad — that got committed by accident, unrelated file. already force-pushed it out, should be gone from the diff now
thomas-vilte
force-pushed
the
feat/silk-math-primitives
branch
from
July 17, 2026 22:34
f89119e to
1d010c0
Compare
thomas-vilte
changed the title
JoTurk
approved these changes
Jul 17, 2026
JoTurk
left a comment
JoTurk
left a comment
Member
There was a problem hiding this comment.
Looks good, we should remove all the nolint:unused when we start using them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add math_fix.go with fixed-point arithmetic primitives copied from libopus Inlines.h and MacroCount.h:
Add lin2log.go with log helpers:
Add math_fix_test.go with tests for div32VarQ, smulwt, addSat32, silkRand.
All functions are tested but currently unused by production code.
They will be consumed by subsequent SILK sub-PRs (VAD, NSQ,
pitch analysis, noise shaping, etc.).