Fix UnknownAttributes encoding to match RFC 5389 - #280
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
=======================================
Coverage 66.43% 66.43%
=======================================
Files 27 27
Lines 2124 2124
=======================================
Hits 1411 1411
Misses 700 700
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sirzooro
force-pushed
the
fix_unknown_attrs
branch
from
June 17, 2026 07:11
221fae6 to
8aee25d
Compare
sirzooro
force-pushed
the
fix_unknown_attrs
branch
from
June 17, 2026 14:30
8aee25d to
9029f90
Compare
JoTurk
approved these changes
Jun 18, 2026
Pion uses 4 bytes per attribute type instead of 2 as specified in RFC 5389. On send side it is not so bad, other STUN peer will see extra zero attributes, so most likely it will be able to deal with this. In opposite direction there is a data loss, half of received attributes is silently discarded when pion decodes received packet.
sirzooro
force-pushed
the
fix_unknown_attrs
branch
from
June 18, 2026 06:37
9029f90 to
548804d
Compare
Contributor
Author
|
Thanks, added new test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pion uses 4 bytes per attribute type instead of 2 as specified in RFC 5389. On send side it is not so bad, other STUN peer will see extra zero attributes, so most likely it will be able to deal with this. In opposite direction there is a data loss, half of received attributes is silently discarded when pion decodes received packet.