-
Notifications
You must be signed in to change notification settings - Fork 357
RFC 6156: TURN Extension for IPv6 #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
==========================================
+ Coverage 81.07% 81.38% +0.30%
==========================================
Files 46 46
Lines 3022 3099 +77
==========================================
+ Hits 2450 2522 +72
- Misses 362 373 +11
+ Partials 210 204 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hot damn that's amazing! Mind squashing into one commit and copying your GitHub message into the commit? Reviewing now. |
|
@adrianosela LGTM! This is really impressive stuff, I am so appreciate of you getting involved :) |
|
Approved, see if you can do the following (totally understand if it isn't possible)
|
9b6e9ee to
b0524c6
Compare
|
@Sean-Der , all reasonable feedback. Will get to it over next few days/weeks. |
539743a to
22fe774
Compare
So, server side we have to rely on the They will be for most, so we can definitely try. I propose we:
I'll make that change and ask you for another review. |
22fe774 to
7c2be8c
Compare
548bc7a to
7b3cb9c
Compare
This PR implements RFC 6156: Traversal Using Relays around NAT (TURN) Extension for IPv6 enabling UDP and TCP relay allocations on IPv6 addresses.
7b3cb9c to
04a5cd5
Compare
JoTurk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any issues :)
RFC 6156: TURN Extension for IPv6
Closes #212
This PR implements RFC 6156: Traversal Using Relays around NAT (TURN) Extension for IPv6 enabling UDP and TCP relay allocations on IPv6 addresses.
cc:// @stv0g, @Sean-Der
Testing: