Skip to content

Only send requested-family for IPV6 allocations#549

Merged
JoTurk merged 1 commit intomasterfrom
requested-address-family
Jan 30, 2026
Merged

Only send requested-family for IPV6 allocations#549
JoTurk merged 1 commit intomasterfrom
requested-address-family

Conversation

@JoTurk
Copy link
Member

@JoTurk JoTurk commented Jan 30, 2026

Description

this helper enforces two constraints on sending REQUESTED-ADDRESS-FAMILY:

  1. no RESERVATION-TOKEN (was already enforced before this PR).
  2. IPV6 is desired.

should fix #547

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.59%. Comparing base (c9702be) to head (adaa9d6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #549      +/-   ##
==========================================
- Coverage   81.63%   81.59%   -0.04%     
==========================================
  Files          46       46              
  Lines        3191     3195       +4     
==========================================
+ Hits         2605     2607       +2     
- Misses        384      385       +1     
- Partials      202      203       +1     
Flag Coverage Δ
go 81.59% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk JoTurk requested review from Sean-Der, adrianosela, philipch07 and rg0now and removed request for Sean-Der January 30, 2026 16:08
@JoTurk
Copy link
Member Author

JoTurk commented Jan 30, 2026

@rg0now based on @philipch07 approval and that you voted for this change in the issue, I'm going to merge and tag this to hopefully fix #547 . it shouldn't break anything.

@JoTurk JoTurk merged commit adaa9d6 into master Jan 30, 2026
19 checks passed
@JoTurk JoTurk deleted the requested-address-family branch January 30, 2026 16:21
@adrianosela
Copy link
Contributor

Thanks for this @JoTurk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Unsupported attribute

3 participants