Merged
Conversation
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
…gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5630 +/- ##
==========================================
+ Coverage 26.58% 26.65% +0.07%
==========================================
Files 477 477
Lines 50657 50740 +83
==========================================
+ Hits 13465 13526 +61
- Misses 36134 36147 +13
- Partials 1058 1067 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ffjlabo
commented
Mar 7, 2025
| @@ -1,95 +0,0 @@ | |||
| // Code generated by MockGen. DO NOT EDIT. | |||
Member
Author
There was a problem hiding this comment.
The linter warns for this file, but actually this file seems to be not needed.
I noticed the mock for the project store is already created in the pkg/datastore/datastoretest.
hongky-1994
pushed a commit
that referenced
this pull request
Mar 11, 2025
* Add gofmt linter Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix deployment_store_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/app/piped/executor/analysis/mannwhitney/udist.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/app/pipedv1/livestatereporter/livestatereporter_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/insight/provider_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/log/log_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix tool/actions-gh-release/comment_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix tool/actions-gh-release/release_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/app/piped/executor/cloudrun/cloudrun.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/app/piped/platformprovider/cloudrun/cloudrun.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix tool/actions-gh-release/github.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix tool/actions-plan-preview/github.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Use datastoretest.MockProjectStore Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> --------- Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: kypham <hongkyhvnh@gmail.com>
khanhtc1202
pushed a commit
that referenced
this pull request
Mar 12, 2025
* Enable `gofmt` linter (#5630) * Add gofmt linter Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix deployment_store_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/app/piped/executor/analysis/mannwhitney/udist.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/app/pipedv1/livestatereporter/livestatereporter_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/insight/provider_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/log/log_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix tool/actions-gh-release/comment_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix tool/actions-gh-release/release_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/app/piped/executor/cloudrun/cloudrun.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/app/piped/platformprovider/cloudrun/cloudrun.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix tool/actions-gh-release/github.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix tool/actions-plan-preview/github.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Use datastoretest.MockProjectStore Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> --------- Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: kypham <hongkyhvnh@gmail.com> * Set default value to depleoyment tracing UI - Add default title commit - hide trace.commitMessage when falsy - hide author when falsy Signed-off-by: kypham <hongkyhvnh@gmail.com> * Update default title of commit deployment tracing Signed-off-by: kypham <hongkyhvnh@gmail.com> --------- Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: kypham <hongkyhvnh@gmail.com> Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title.
The target files are those below.
Every fix doesn't have any logic changes.
Why we need it:
We can detect some patterns.
TypeConditions = map[string]struct{}{ - "Active": struct{}{}, - "Ready": struct{}{}, - "ConfigurationsReady": struct{}{}, - "RoutesReady": struct{}{}, - "ContainerHealthy": struct{}{}, - "ResourcesAvailable": struct{}{}, - } + TypeConditions = map[string]struct{}{ + "Active": {}, + "Ready": {}, + "ConfigurationsReady" {}, + "RoutesReady": {}, + "ContainerHealthy": {}, + "ResourcesAvailable": {}, + }Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: