Add default values for deployment traces info if values falsy#5646
Merged
khanhtc1202 merged 4 commits intomasterfrom Mar 12, 2025
Merged
Add default values for deployment traces info if values falsy#5646khanhtc1202 merged 4 commits intomasterfrom
khanhtc1202 merged 4 commits intomasterfrom
Conversation
* Add gofmt linter Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix deployment_store_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/app/piped/executor/analysis/mannwhitney/udist.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/app/pipedv1/livestatereporter/livestatereporter_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/insight/provider_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/log/log_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix tool/actions-gh-release/comment_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix tool/actions-gh-release/release_test.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/app/piped/executor/cloudrun/cloudrun.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix pkg/app/piped/platformprovider/cloudrun/cloudrun.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix tool/actions-gh-release/github.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix tool/actions-plan-preview/github.go for 'gofmt -s' Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Use datastoretest.MockProjectStore Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> --------- Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: kypham <hongkyhvnh@gmail.com>
- Add default title commit - hide trace.commitMessage when falsy - hide author when falsy Signed-off-by: kypham <hongkyhvnh@gmail.com>
hongky-1994
requested review from
Warashi,
ffjlabo,
khanhtc1202 and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5646 +/- ##
=======================================
Coverage 25.53% 25.53%
=======================================
Files 477 477
Lines 51022 51022
=======================================
Hits 13030 13030
Misses 36987 36987
Partials 1005 1005 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t-kikuc
changed the title
khanhtc1202
reviewed
Mar 11, 2025
web/src/components/deployment-trace-page/deployment-trace-item/index.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: kypham <hongkyhvnh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add default values for deployment traces info if values falsy
Commit title ${trace?.commitHash}Why we need it:
Which issue(s) this PR fixes:
Part of #5444
Does this PR introduce a user-facing change?: no