Skip to content

Update pipectl event register to support deployment trace feature#5650

Merged
khanhtc1202 merged 1 commit intomasterfrom
event-register-trace
Mar 12, 2025
Merged

Update pipectl event register to support deployment trace feature#5650
khanhtc1202 merged 1 commit intomasterfrom
event-register-trace

Conversation

@khanhtc1202
Copy link
Member

What this PR does:

This PR updates the pipette event register command to add commit-related data as part of the event submission to the control plane. The deployment trace feature will use this information.

Why we need it:

Which issue(s) this PR fixes:

Part of #5444

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) March 12, 2025 08:56
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 25.56%. Comparing base (16089a9) to head (fbf1062).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipectl/cmd/event/register.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5650      +/-   ##
==========================================
- Coverage   25.56%   25.56%   -0.01%     
==========================================
  Files         477      477              
  Lines       51080    51091      +11     
==========================================
  Hits        13060    13060              
- Misses      37015    37026      +11     
  Partials     1005     1005              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 merged commit c52ff8c into master Mar 12, 2025
16 of 18 checks passed
@khanhtc1202 khanhtc1202 deleted the event-register-trace branch March 12, 2025 09:16
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants