Skip to content

Add timestamp of the commit as event register flag#5653

Merged
khanhtc1202 merged 1 commit intomasterfrom
commit-timestamp-event-register
Mar 12, 2025
Merged

Add timestamp of the commit as event register flag#5653
khanhtc1202 merged 1 commit intomasterfrom
commit-timestamp-event-register

Conversation

@khanhtc1202
Copy link
Member

What this PR does:

as title

Why we need it:

The user of pipectl should have a way to submit the timestamp of the commit that triggers the event (eventwatcher register feature)

Which issue(s) this PR fixes:

Follow PR #5650

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) March 12, 2025 09:26
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 25.55%. Comparing base (c52ff8c) to head (08f5bf0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipectl/cmd/event/register.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5653      +/-   ##
==========================================
+ Coverage   25.54%   25.55%   +0.01%     
==========================================
  Files         477      477              
  Lines       51099    51101       +2     
==========================================
+ Hits        13054    13060       +6     
+ Misses      37040    37036       -4     
  Partials     1005     1005              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khanhtc1202 khanhtc1202 merged commit d50a676 into master Mar 12, 2025
17 of 18 checks passed
@khanhtc1202 khanhtc1202 deleted the commit-timestamp-event-register branch March 12, 2025 13:44
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants