Merged
Conversation
Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com>
na-ga
force-pushed
the
add-temporary-volume-option
branch
from
3bc3fb8 to
bd40839
Compare
Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com>
na-ga
requested review from
Warashi,
ffjlabo,
khanhtc1202 and
t-kikuc
as code owners
Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com>
ffjlabo
approved these changes
Apr 2, 2025
Member
ffjlabo
left a comment
ffjlabo
left a comment
There was a problem hiding this comment.
Thank you for the PR!
I test it on the kind cluster and checked the PVC are attached to the piped pod.
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2025
* add: temporary volume option Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> * remove: post start Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> * add: storage class name Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> --------- Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2025
* add: temporary volume option Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> * remove: post start Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> * add: storage class name Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> --------- Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
ffjlabo
pushed a commit
that referenced
this pull request
Apr 3, 2025
* add: temporary volume option Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> * remove: post start Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> * add: storage class name Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> --------- Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
ffjlabo
added a commit
that referenced
this pull request
Apr 3, 2025
* add: temporary volume option (#5716) * add: temporary volume option Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> * remove: post start Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> * add: storage class name Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> --------- Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Fix rolling back deployments are ignored on piped restarted event (#5717) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> * Release v0.51.1 (#5718) Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> --------- Signed-off-by: na-ga <537006+na-ga@users.noreply.github.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Co-authored-by: Na-ga <537006+na-ga@users.noreply.github.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Added option to use PVC as temporary volume
Why we need it:
I need a workaround for a disk full problem caused by a temporary file generated by piped
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: