Skip to content

Modify volume name attached to deployment#5734

Merged
ffjlabo merged 1 commit intomasterfrom
modify-pvc-name-attached-to-deployment
Apr 14, 2025
Merged

Modify volume name attached to deployment#5734
ffjlabo merged 1 commit intomasterfrom
modify-pvc-name-attached-to-deployment

Conversation

@ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Apr 11, 2025

What this PR does:

Fixed to be able to change volume name when setting it on values.yaml .

Why we need it:

Users can't set the volume name as is for now.

Which issue(s) this PR fixes:

Follow #5716

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.99%. Comparing base (b6c89b1) to head (ca0ab11).
Report is 130 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5734      +/-   ##
==========================================
+ Coverage   26.96%   26.99%   +0.03%     
==========================================
  Files         503      503              
  Lines       53024    53048      +24     
==========================================
+ Hits        14297    14321      +24     
  Misses      37663    37663              
  Partials     1064     1064              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks

Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffjlabo ffjlabo merged commit d24a475 into master Apr 14, 2025
18 checks passed
@ffjlabo ffjlabo deleted the modify-pvc-name-attached-to-deployment branch April 14, 2025 06:58
@ffjlabo ffjlabo added this to v0.51.2 Apr 14, 2025
@ffjlabo ffjlabo moved this to Done in v0.51.2 Apr 14, 2025
github-actions bot pushed a commit that referenced this pull request Apr 18, 2025
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
khanhtc1202 added a commit that referenced this pull request Apr 18, 2025
* fix: upgrade react-router-dom from 6.29.0 to 6.30.0 (#5686)

Snyk has created this PR to upgrade react-router-dom from 6.29.0 to 6.30.0.

See this package in yarn:
react-router-dom

See this project in Snyk:
https://app.snyk.io/org/pipecd/project/f41c5767-b506-4f59-beb9-ef662258eb9a?utm_source=github&utm_medium=referral&page=upgrade-pr

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Revert "Temporary disable v1 add application form on UI (#5694)" (#5696)

This reverts commit dca04f9.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Use nodejs 20 as web image builder (#5726)

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* add labels to application delete dialog box (#5727)

Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* fix: regex based tag replacement scheme (#5730)

* fix: regex based tag replacement scheme

Signed-off-by: GotoRen <r0719en@pluslab.org>

* fix: nits comment

Signed-off-by: GotoRen <r0719en@pluslab.org>

* fix: copy changes into main implementation

Signed-off-by: GotoRen <r0719en@pluslab.org>

---------

Signed-off-by: GotoRen <r0719en@pluslab.org>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Modify pvc name attached to deployment (#5734)

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* fix piped name suggestion when adding new application (#5735)

Signed-off-by: Dave Canton <dvcanton7@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Disable register app for pipedv1 form (#5739)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Bump golang.org/x/net from 0.36.0 to 0.38.0 in /tool/actions-gh-release (#5741)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.36.0 to 0.38.0.
- [Commits](golang/net@v0.36.0...v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.38.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Bump http-proxy-middleware from 2.0.7 to 2.0.9 in /web (#5742)

Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.7 to 2.0.9.
- [Release notes](https://github.com/chimurai/http-proxy-middleware/releases)
- [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.9/CHANGELOG.md)
- [Commits](chimurai/http-proxy-middleware@v2.0.7...v2.0.9)

---
updated-dependencies:
- dependency-name: http-proxy-middleware
  dependency-version: 2.0.9
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Update go-jwt to version 5.2.2 (#5743)

* Update go-jwt to version 5.2.2

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

* Use the previous signing method

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>

---------

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Bump golang.org/x/net in /tool/actions-plan-preview (#5745)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.36.0 to 0.38.0.
- [Commits](golang/net@v0.36.0...v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.38.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Bump golang.org/x/net from 0.36.0 to 0.38.0 (#5746)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.36.0 to 0.38.0.
- [Commits](golang/net@v0.36.0...v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-version: 0.38.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Cut release v0.51.2 (#5753)

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: khanhtc1202 <32532742+khanhtc1202@users.noreply.github.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

---------

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: GotoRen <r0719en@pluslab.org>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Dave Canton <dvcanton7@gmail.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Chris Aniszczyk <caniszczyk@gmail.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Co-authored-by: Harshit Gupta <105965263+atpugtihsrah@users.noreply.github.com>
Co-authored-by: Ren Goto (@ren510dev) <r0719en@pluslab.org>
Co-authored-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
Co-authored-by: Dave <dvcanton7@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request May 15, 2025
@github-actions github-actions bot mentioned this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants