Update project architecture#80
Merged
Merged
Conversation
Since it is very unlikely to do Eclipse RCP development without Eclipse IDE, those files actually make easier to share projects between developers.
This architecture: - relies on a target platform to avoid platform-dependent builds - uses only OSGi bundles and avoids declaring dependencies in POM files This commit introduces some major version changes: - bump Java version to 1.8 - bump Pitest version to 1.4.6 - bump project's version to 2.0.0-SNAPSHOT checkstyle.xml has also been slightly modified: - remove deprecated maxLineLength property of LeftCurly rule - allow methods that start with a single lower case letter Also clean code style so that it is consistent and in accordance with Checkstyle's rules (fixes #70). Build is automated with Travis CI (#69).
.story files are used by JBehave to describe tests in a Gherkin syntax .feature files are used by Cucumber to describe tests in a Gherkin syntax Since we are going to replace JBehave with Cucumber, we have to rename the existing .story files. This commit allows Git to keep the history of changes of those files.
This commit uses Cucumber instead of JBehave to run BDD tests. I made this choice because Cucumber seemed easier to integrate within a Tycho build, especially because JBehave's JAR does not include its dependencies. As the two libraries usedvery similar API, changes made to the code are really minor. /!\ 1 test still fail, likely because the away launch configurations are created has changed Travis CI is able to run UI tests (#6).
echebbi
changed the title
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=========================================
Coverage ? 85.02%
Complexity ? 299
=========================================
Files ? 45
Lines ? 1242
Branches ? 88
=========================================
Hits ? 1056
Misses ? 126
Partials ? 60
Continue to review full report at Codecov.
|
echebbi
added a commit
that referenced
this pull request
Aug 14, 2019
This commit corresponds to the following PR: - #80 Its purpose is to ensure that the reason why Travis fails to build PR#80 is that the PR comes from a fork and, as a result, is not allowed to use Travis CI's encrypted variables. Since this branch is internal, the build should be successful.
Update code according to Checkstyle's rules.
The new jacoco Maven profile allows to compute code's coverage thanks to JaCoCo. It can be used as follows: * mvn verify -P jacoco All reports are aggregated by the org.pitest.pitclipse.tests.coverage.report module and then sent to CodeCov.
Sonar analysis is only run when the branch belongs to the pitest/pitclipse repository. Indeed, sending the results of the the analysis to SonarCloud requires the encrypted SONAR token which is not provided by Travis CI when the build comes from a fork. The code checking whether the analysis can be run is located in .travis/build.sh and is called by the .travis.yml configuration file. I also struggled a bit to encrypt the token because encryption on travis-ci.com is different from encryption on travis-ci.org. For the record here is what I did: > travis login --pro > travis encrypt --pro <token> -r pitest/pitclipse
This was referenced Aug 15, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not much functional changes, but important refactoring of Pitclipse's architecture.
Changes in the architecture
The new architecture:
Version changes
This PR also introduces some major version changes:
Code quality improvement
checkstyle.xml has also been slightly modified:
maxLineLengthproperty ofLeftCurlyruleThe code has been cleaned so that it is consistent and in accordance with Checkstyle's rules.
More tests are automated
Both unit & integration tests are launched by Travis CI.
Improved documentation
License headers have been added to source files.
Added some Markdown files that:
Fixed issues
This PR should fix the following issues: