Connect unused RhythmDescriptors sources in EssentiaBpmDetector#72
Merged
Conversation
Newer Essentia requires every streaming source to be connected to a sink. RhythmDescriptors exposes many outputs beyond bpm/confidence, and leaving them dangling raised "beats_position is not connected to any sink", causing EssentiaBpmDetector.detect to fail and silently fall back to PercivalBpmDetector. Connect the unused sources to None so the higher-quality detector runs again. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
EssentiaBpmDetectorwas silently failing on every file:Newer Essentia requires every streaming source on an algorithm to be connected to a sink. The script only connected
bpmandconfidence, leaving the remainingRhythmDescriptorsoutputs dangling. This raised the error,detectreturnednil, and analyze silently fell back toPercivalBpmDetector— so BPMs were still produced, but the higher-quality detector never actually ran.Fix
Connect the unused
RhythmDescriptorssources toNone, Essentia's idiomatic way to discard a streaming output. KeptRhythmDescriptorsrather than switching toRhythmExtractor2013to minimize the change.Testing
Verified against a fixture —
detectnow returns a result instead of raising:(Synthetic test tone, hence
confidence: 0.0; the point is no exception and the Essentia path now runs.)🤖 Generated with Claude Code