Skip to content

[Issue #30]: make NUMA interleaved. #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bianhq merged 1 commit into from
Aug 2, 2019
Merged

[Issue #30]: make NUMA interleaved. #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pixels-presto/src/main/java/io/pixelsdb/pixels/presto/PixelsSplitManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
import static java.util.stream.Collectors.toSet;

/**
* @author: tao
* @author: hank, guodong jin, tao
* @date: Create in 2018-01-20 19:16
**/
@SuppressWarnings("Duplicates")
Expand Down
2 changes: 1 addition & 1 deletion pixels-presto/src/main/java/io/pixelsdb/pixels/presto/block/VarcharArrayBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
/**
* This class refers to com.facebook.presto.spi.block.VariableWidthBlock and AbstractVariableWidthBlock.
*
* Modifies:
* Modifications:
* 1. we use a byte[][] instead of Slice as the backing storage
* and replaced the implementation of each methods;
* 2. add some other methods.
Expand Down
9 changes: 7 additions & 2 deletions scripts/bin/run-class.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,15 @@ fi

echo "PIXELS OPTS: "$PIXELS_OPTS

NUMA_INTERLEAVE=""
if type numactl >/dev/null 2>&1; then
NUMA_INTERLEAVE="numactl --interleave=all"
fi

# Launch mode
if [ "x$DAEMON_MODE" = "xtrue" ]; then
echo "$DAEMON_NAME running in the daemon mode."
nohup ${JAVA} ${PIXELS_HEAP_OPTS} ${PIXELS_JVM_PERFORMANCE_OPTS} -cp ${CLASSPATH} ${PIXELS_OPTS} "$@" > ${CONSOLE_OUTPUT_FILE} 2>&1 < /dev/null &
nohup ${NUMA_INTERLEAVE} ${JAVA} ${PIXELS_HEAP_OPTS} ${PIXELS_JVM_PERFORMANCE_OPTS} -cp ${CLASSPATH} ${PIXELS_OPTS} "$@" > ${CONSOLE_OUTPUT_FILE} 2>&1 < /dev/null &
else
exec ${JAVA} ${PIXELS_HEAP_OPTS} ${PIXELS_JVM_PERFORMANCE_OPTS} -cp ${CLASSPATH} ${PIXELS_OPTS} "$@"
exec ${NUMA_INTERLEAVE} ${JAVA} ${PIXELS_HEAP_OPTS} ${PIXELS_JVM_PERFORMANCE_OPTS} -cp ${CLASSPATH} ${PIXELS_OPTS} "$@"
fi