Skip to content

[actions] Use buildbuddy only on self-hosted runners#1109

Merged
aimichelle merged 1 commit intopixie-io:mainfrom
JamesMBartlett:github_bazelrc
Mar 29, 2023
Merged

[actions] Use buildbuddy only on self-hosted runners#1109
aimichelle merged 1 commit intopixie-io:mainfrom
JamesMBartlett:github_bazelrc

Conversation

@JamesMBartlett
Copy link
Copy Markdown
Member

Summary: We don't want to use buildbuddy from github actions directly because of potential egress/ingress costs from github actions to gcloud. Instead once #1108 lands, self-hosted runners will have access to buildbuddy. This PR replaces adding the buildbuddy api key with adding github specific bazelrc options.

Type of change: /kind test-infra

Test Plan: Tested that these configs work in #1054

Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
@JamesMBartlett JamesMBartlett changed the title [actions] Don't use buildbuddy from github actions directly [actions] Use buildbuddy only on self-hosted runners Mar 28, 2023
@JamesMBartlett
Copy link
Copy Markdown
Member Author

@pixie-io-buildbot test this please

@JamesMBartlett JamesMBartlett marked this pull request as ready for review March 28, 2023 23:38
@JamesMBartlett JamesMBartlett requested a review from a team as a code owner March 28, 2023 23:38
@aimichelle aimichelle merged commit c236d4a into pixie-io:main Mar 29, 2023
ddelnano pushed a commit to ddelnano/pixie that referenced this pull request May 1, 2023
Summary: We don't want to use buildbuddy from github actions directly
because of potential egress/ingress costs from github actions to gcloud.
Instead once pixie-io#1108 lands, self-hosted runners will have access to
buildbuddy. This PR replaces adding the buildbuddy api key with adding
github specific bazelrc options.

Type of change: /kind test-infra

Test Plan: Tested that these configs work in pixie-io#1054

Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
ddelnano pushed a commit to k8sstormcenter/pixie that referenced this pull request Feb 25, 2026
Summary: We don't want to use buildbuddy from github actions directly
because of potential egress/ingress costs from github actions to gcloud.
Instead once pixie-io#1108 lands, self-hosted runners will have access to
buildbuddy. This PR replaces adding the buildbuddy api key with adding
github specific bazelrc options.

Type of change: /kind test-infra

Test Plan: Tested that these configs work in pixie-io#1054

Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
ddelnano pushed a commit to k8sstormcenter/pixie that referenced this pull request Feb 25, 2026
Summary: We don't want to use buildbuddy from github actions directly
because of potential egress/ingress costs from github actions to gcloud.
Instead once pixie-io#1108 lands, self-hosted runners will have access to
buildbuddy. This PR replaces adding the buildbuddy api key with adding
github specific bazelrc options.

Type of change: /kind test-infra

Test Plan: Tested that these configs work in pixie-io#1054

Signed-off-by: James Bartlett <jamesbartlett@pixielabs.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants