Revert "Added cgid capture to stirling with testing (#1681)"#1738
Merged
aimichelle merged 1 commit intopixie-io:mainfrom Oct 17, 2023
Merged
Revert "Added cgid capture to stirling with testing (#1681)"#1738aimichelle merged 1 commit intopixie-io:mainfrom
aimichelle merged 1 commit intopixie-io:mainfrom
Conversation
benkilimnik
force-pushed
the
revert-cgid
branch
from
ef24842 to
850396f
Compare
Member
|
cc @AdityaAtulTewari. We will need to update your original change to include some type of kernel version detection and only add the cgroup id on supported kernels. |
Signed-off-by: Benjamin Kilimnik <bkilimnik@pixielabs.ai>
benkilimnik
force-pushed
the
revert-cgid
branch
from
850396f to
82c15e4
Compare
ddelnano
approved these changes
Oct 17, 2023
aimichelle
approved these changes
Oct 17, 2023
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
…ixie-io#1738) Summary: Revert cgid capture This change reverts capturing Cgroup ids from pixie-io@2a2349f. Many of the 4.14 kernel tests have [BPF compilation errors](https://app.buildbuddy.io/invocation/075de8d0-d161-4ff6-8b74-123c6da66778#): `HINT: bpf_get_current_cgroup_id missing (added in Linux 4.18)`. Perplexingly, GitHub seems to show these tests as [passing despite the failures](https://github.com/pixie-io/pixie/actions/runs/6366478258/job/17320729511). Relevant Issues: pixie-io#1638 pixie-io#1739 Type of change: /kind bug Test Plan: Running CI Signed-off-by: Benjamin Kilimnik <bkilimnik@pixielabs.ai>
ddelnano
pushed a commit
to k8sstormcenter/pixie
that referenced
this pull request
Feb 25, 2026
…ixie-io#1738) Summary: Revert cgid capture This change reverts capturing Cgroup ids from pixie-io@2a2349f. Many of the 4.14 kernel tests have [BPF compilation errors](https://app.buildbuddy.io/invocation/075de8d0-d161-4ff6-8b74-123c6da66778#): `HINT: bpf_get_current_cgroup_id missing (added in Linux 4.18)`. Perplexingly, GitHub seems to show these tests as [passing despite the failures](https://github.com/pixie-io/pixie/actions/runs/6366478258/job/17320729511). Relevant Issues: pixie-io#1638 pixie-io#1739 Type of change: /kind bug Test Plan: Running CI Signed-off-by: Benjamin Kilimnik <bkilimnik@pixielabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Revert cgid capture
This change reverts capturing Cgroup ids from 2a2349f. Many of the 4.14 kernel tests have BPF compilation errors:
HINT: bpf_get_current_cgroup_id missing (added in Linux 4.18). Perplexingly, GitHub seems to show these tests as passing despite the failures.Relevant Issues: #1638 #1739
Type of change: /kind bug
Test Plan: Running CI