Open
Conversation
Signed-off-by: AdityaAtulTewari <adityaatewari@gmail.com>
Signed-off-by: AdityaAtulTewari <adityaatewari@gmail.com>
Signed-off-by: AdityaAtulTewari <adityaatewari@gmail.com>
Signed-off-by: AdityaAtulTewari <adityaatewari@gmail.com>
ddelnano
reviewed
Oct 20, 2023
Signed-off-by: AdityaAtulTewari <adityaatewari@gmail.com>
a47e3b2 to
f389cc3
Compare
Signed-off-by: AdityaAtulTewari <adityaatewari@gmail.com>
4acaa62 to
2f2a5e8
Compare
Signed-off-by: AdityaAtulTewari <adityaatewari@gmail.com>
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Jan 12, 2024
…resource to support concatenated (not preprocessed) header files Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Member
|
@AdityaAtulTewari sorry for the late reply here. The solution I envisioned was what I've implemented in 3bab3f0. That change isn't production ready, but shows how the In order to move forward with this, I think we will need some feedback on this approach from @vihangm and @JamesMBartlett. If this is something we are comfortable with, then we can shape up what I've prototyped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This is to ensure that the reversions in #1738 are not necessary for #1638. It enables a flag for bcc compilation for detecting that the
bpf_get_current_cgroup_idexists within that kernel version. That flag isGET_CGROUP_ID_ENABLED. And an example of it's usage is insrc/stirling/bpf_tools/testdata/get_current_cgroup_id.c.Type of change: /kind feature
Test Plan: Automated test added to ensure that this feature is enabled and works.
Signed-off-as: AdityaAtulTewari adityaatewari@gmail.com