Ratchet unicorn/better-dom-traversing + prefer-number-is-safe-integer to error#280
Merged
Merged
Conversation
… to error First ratchet from #279. Both are small, source-only, zero-risk: - page-tree.ts: `.childNodes[0]` → `.firstChild` (coerce the null the property returns to undefined to match `getElementTree`'s return type). - lifecycle.ts: `Number.isInteger(tabId)` → `Number.isSafeInteger(tabId)` at the two tab-id guards. Both rules drop back to their unicorn/recommended default (error). Refs #279 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First ratchet from #279 — the smallest, lowest-risk pair.
Changes
src/lib/page-tree.ts:.childNodes[0]→.firstChild(2 sites)..firstChildreturnsChildNode | nullwhilegetElementTreereturnsNode | undefined, so the return coercesnull→undefined. Behaviorally identical (childNodes[0]≡firstChild).src/lib/background/lifecycle.ts:Number.isInteger(tabId)→Number.isSafeInteger(tabId)(2 sites). Tab IDs are well within safe-integer range, so this is strictly more correct.eslint.config.js: both rules removed from the warn list, reverting to their unicorn/recommended default (error).Verification
bun run typecheckcleanbun run checkexit 0 (the two rules now error; 0 errors remain)bun run test— 2059/2059 passRefs #279