Ratchet unicorn/prefer-type-literal-last to error#282
Merged
Conversation
Third ratchet from #279. Type-only change: reorder the five `{ type: "…" } & EventType` intersections so the object type literal comes last (`EventType & { type: "…" }`). Intersection is commutative, so this is purely cosmetic — no runtime or type-checking behavior change. - detection-messages.ts: DebugTraceEntry union (3 members) - rule-count.test.ts, trace-mutation.test.ts: type-guard predicates Rule reverts to its unicorn/recommended default (error). Refs #279 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![unblocked[bot]](https://avatars.githubusercontent.com/in/166219?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third ratchet from #279 (now that #280 and #281 have merged, this targets
main).Type-only change: the five flagged sites are all
{ type: "…" } & EventTypeintersections, reordered so the object type literal comes last (EventType & { type: "…" }). Intersection is commutative — zero runtime or type-checking behavior change.detection-messages.ts—DebugTraceEntryunion (3 members)rule-count.test.ts,trace-mutation.test.ts— type-guard predicateseslint.config.js: rule removed from the warn list → reverts to unicorn/recommended default (error).Verification:
typecheckclean,checkexit 0 (0 violations),test2059/2059 pass.Refs #279