Skip to content

PythonCheckCompat: add overlays support#334

Closed
CyberTailor wants to merge 1 commit intopkgcore:masterfrom
CyberTailor:master
Closed

PythonCheckCompat: add overlays support#334
CyberTailor wants to merge 1 commit intopkgcore:masterfrom
CyberTailor:master

Conversation

@CyberTailor
Copy link
Copy Markdown
Contributor

@CyberTailor CyberTailor commented Jul 16, 2021

No description provided.

@CyberTailor CyberTailor changed the title PythonCheckCompat: use fallback repo PythonCheckCompat,DependencyCheck: add overlays support Jul 16, 2021
@CyberTailor CyberTailor force-pushed the master branch 2 times, most recently from 3c0c68b to 19a80a5 Compare July 20, 2021 19:04
@mgorny
Copy link
Copy Markdown
Contributor

mgorny commented Aug 4, 2021

Just to be clear (I'm new to overlay support in pkgcore), what order are target_repos in? ::gentoo first or overlay first?

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 4, 2021

Codecov Report

Merging #334 (6a984e6) into master (1c219be) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #334   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files          54       54           
  Lines        7364     7364           
  Branches     1783     1783           
=======================================
  Hits         7033     7033           
  Misses        204      204           
  Partials      127      127           
Impacted Files Coverage Δ
src/pkgcheck/checks/python.py 96.53% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c219be...6a984e6. Read the comment docs.

@CyberTailor
Copy link
Copy Markdown
Contributor Author

self.options.target_repo is an overlay
self.options.target_repo.trees is that overlay with its masters (masters go first)

Comment thread src/pkgcheck/checks/metadata.py Outdated
Comment thread src/pkgcheck/checks/python.py Outdated
@CyberTailor CyberTailor changed the title PythonCheckCompat,DependencyCheck: add overlays support PythonCheckCompat: add overlays support Dec 11, 2021
@CyberTailor
Copy link
Copy Markdown
Contributor Author

This is ready to be merged

@mgorny
Copy link
Copy Markdown
Contributor

mgorny commented Mar 21, 2022

Thanks! Let's just let the CI finish.

@mgorny mgorny closed this in 723a8f8 Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants