new check: using reserved names#378
Merged
arthurzam merged 1 commit intopkgcore:masterfrom May 20, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
==========================================
+ Coverage 95.57% 95.64% +0.07%
==========================================
Files 54 55 +1
Lines 7450 7512 +62
Branches 1813 1829 +16
==========================================
+ Hits 7120 7185 +65
+ Misses 204 203 -1
+ Partials 126 124 -2
Continue to review full report at Codecov.
|
laumann
reviewed
May 17, 2022
laumann
reviewed
May 17, 2022
laumann
reviewed
May 17, 2022
ulm
reviewed
May 17, 2022
Contributor
|
Exceptions that should be added (Portage variables whose use is half-legitimate and harmless if the package manager doesn't support them):
|
laumann
reviewed
May 17, 2022
laumann
reviewed
May 17, 2022
laumann
reviewed
May 17, 2022
laumann
reviewed
May 17, 2022
thesamesam
reviewed
May 20, 2022
thesamesam
reviewed
May 20, 2022
thesamesam
reviewed
May 20, 2022
thesamesam
approved these changes
May 20, 2022
Based on updated PMS rules [1] around reserved for package manager function and variable names. Add the check for eclasses and ebuilds. [1] https://gitweb.gentoo.org/proj/pms.git/commit/?id=260e21bf65f Bug: https://bugs.gentoo.org/843779 Bug: https://bugs.gentoo.org/843680 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
arthurzam
force-pushed
the
check-reserved-names
branch
from
3b67177 to
9e45325
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on updated PMS rules around reserved for package manager
function and variable names. Add the check for eclasses and ebuilds.
@thesamesam @ulm
Please also look at the regex I used for 'ebuild' case that I understood correctly the rule.
Results for the run over gentoo tree