Skip to content

checks: Sync remote-id types with wiki and test all of them#386

Merged
arthurzam merged 1 commit intomasterfrom
remote-ids
May 25, 2022
Merged

checks: Sync remote-id types with wiki and test all of them#386
arthurzam merged 1 commit intomasterfrom
remote-ids

Conversation

@mgorny
Copy link
Copy Markdown
Contributor

@mgorny mgorny commented May 24, 2022

TODO: rename DeadUrl to DeadUrl-github and try adding a test for bugs-to

(apparently we check bugs-to in another test)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2022

Codecov Report

Merging #386 (6f765e9) into master (88988df) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 6f765e9 differs from pull request most recent head 051a298. Consider uploading reports for the commit 051a298 to get more accurate results

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   95.64%   95.73%   +0.08%     
==========================================
  Files          55       55              
  Lines        7513     7619     +106     
  Branches     1830     1889      +59     
==========================================
+ Hits         7186     7294     +108     
  Misses        203      203              
+ Partials      124      122       -2     
Impacted Files Coverage Δ
src/pkgcheck/checks/network.py 79.21% <ø> (ø)
src/pkgcheck/checks/python.py 98.37% <0.00%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97370ba...051a298. Read the comment docs.

@mgorny mgorny force-pushed the remote-ids branch 2 times, most recently from a02268f to 6f765e9 Compare May 25, 2022 19:27
@mgorny mgorny changed the title checks: Sync remote-id types with wiki and test all of them [WIP] checks: Sync remote-id types with wiki and test all of them May 25, 2022
Copy link
Copy Markdown
Member

@arthurzam arthurzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Signed-off-by: Michał Górny <mgorny@gentoo.org>
@arthurzam arthurzam merged commit 051a298 into master May 25, 2022
@arthurzam arthurzam deleted the remote-ids branch May 25, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants