add a check for remote-id validity

[mgorny]

Add an auxiliary check for invalid remote-id values.  At the moment,
it primarily checks for the correct number of path components and some
obvious mistakes.  In the future, the regular expressions can be
improved to catch invalid user/project names as well.

This includes tests for common valid and invalid values for the current
set of remote-ids.  In addition to that, PkgMetadataXmlEmptyElement
check is extended to cover "empty <remote-id/>" path in the code.
Unfortunately, covering "unknown type" path is non-trivial as it
requires a remote-id type that is allowed by the XML Schema but not
covered by validation (which normally happens only when Schema is
updated).

This also requires bumping the minimal pkgcore version in order to grab
XML Schema updates (adding "osdn" remote type).

Current output

$ pkgcheck scan -k InvalidRemoteID
app-backup/deja-dup
  InvalidRemoteID: remote-id value 'https://gitlab.gnome.org/World/deja-dup' invalid for type='gitlab', expected: '{username}/[{group}/...]{repo}'

app-crypt/adcli
  InvalidRemoteID: remote-id value 'https://gitlab.freedesktop.org/realmd/adcli' invalid for type='gitlab', expected: '{username}/[{group}/...]{repo}'

app-emulation/wine-gecko
  InvalidRemoteID: remote-id value 'wine/wine-gecko' invalid for type='sourceforge', expected: '{project}'

app-text/pdfgrep
  InvalidRemoteID: remote-id value 'pdfgrep' invalid for type='gitlab', expected: '{username}/[{group}/...]{repo}'

dev-go/gopls
  InvalidRemoteID: remote-id value 'golang/tools/gopls' invalid for type='github', expected: '{username}/{project}'

dev-java/fec
  InvalidRemoteID: remote-id value 'onionnetworks' invalid for type='bitbucket', expected: '{username}/{project}'

dev-java/jackson-dataformat-yaml
  InvalidRemoteID: remote-id value 'https://github.com/FasterXML/jackson-dataformats-text/issues' invalid for type='github', expected: '{username}/{project}'

dev-java/junitparams
  InvalidRemoteID: remote-id value 'Pragmatists/JUnitParams/tags' invalid for type='github', expected: '{username}/{project}'

dev-libs/thrift
  InvalidRemoteID: remote-id value 'apache/thrift/' invalid for type='github', expected: '{username}/{project}'

dev-php/webmozart-assert
  InvalidRemoteID: remote-id value 'webmozart/' invalid for type='github', expected: '{username}/{project}'

dev-python/clikit
  InvalidRemoteID: remote-id value 'clikit' invalid for type='github', expected: '{username}/{project}'

dev-python/statsmodels
  InvalidRemoteID: remote-id value 'statsmodels' invalid for type='github', expected: '{username}/{project}'

dev-python/translate-toolkit
  InvalidRemoteID: remote-id value 'translate' invalid for type='github', expected: '{username}/{project}'

dev-scheme/racket
  InvalidRemoteID: remote-id value 'racket' invalid for type='github', expected: '{username}/{project}'

media-radio/js8call
  InvalidRemoteID: remote-id value 'js8call' invalid for type='bitbucket', expected: '{username}/{project}'

net-analyzer/gvm
  InvalidRemoteID: remote-id value 'greenbone' invalid for type='github', expected: '{username}/{project}'

sci-libs/symmetrica
  InvalidRemoteID: remote-id value 'https://gitlab.com/sagemath/symmetrica' invalid for type='gitlab', expected: '{username}/[{group}/...]{repo}'

x11-themes/ubuntu-wallpapers
  InvalidRemoteID: remote-id value 'ubuntu/+source/ubuntu-wallpapers' invalid for type='launchpad', expected: '{project}'

[codecov]

Codecov Report

Merging #387 (cf29c73) into master (a054f7f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head cf29c73 differs from pull request most recent head 97370ba. Consider uploading reports for the commit 97370ba to get more accurate results

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
+ Coverage   95.66%   95.67%   +0.01%     
==========================================
  Files          55       55              
  Lines        7543     7565      +22     
  Branches     1838     1842       +4     
==========================================
+ Hits         7216     7238      +22     
  Misses        203      203              
  Partials      124      124              

Impacted Files	Coverage Δ
src/pkgcheck/checks/metadata_xml.py	96.69% <100.00%> (+0.25%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a054f7f...97370ba. Read the comment docs.

[mgorny]

• figured out how to make gentoo work with a regexp (without extra class)
• added check for lp: prefix in launchpad names

[arthurzam]

I think we should also add a testdata/repos/standalone/PackageMetadataXmlCheck/ValidRemoteID/metadata.xml which will hold valid remotes (one for each remote).

[mgorny]

Ok, I don't think we can cover the KeyError case as that would require having an XML Schema entry without a validator.

[mgorny]

Ah, right, need to bump pkgcore dep to get fresh XML Schema.

[mgorny]

Ok, I think it's ready now.

[arthurzam]

Looks great. Thank you!