GitPkgCommitsCheck: fix files check#393
Merged
arthurzam merged 1 commit intopkgcore:masterfrom May 26, 2022
Merged
Conversation
arthurzam
force-pushed
the
fix-commit-checks
branch
from
a9c3fc2 to
e6fb1a1
Compare
When using _RemovalRepo for previous git state repo, it uses UnconfiguredTree::_pkg_filter as default pkg_filter. During the check for various bad file, it tries to parse the ebuild, which in turn tries to check the usage around inherited eclasses - which doesn't exist in this repo. In theory, the setting of masters repo as the original one should suffice, but it doesn't in practice. For now, let's copy the eclass content so at least this very important check is done! Fixes: pkgcore#381 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
arthurzam
force-pushed
the
fix-commit-checks
branch
from
e6fb1a1 to
9ed3caa
Compare
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
==========================================
- Coverage 95.68% 95.65% -0.03%
==========================================
Files 55 55
Lines 7570 7573 +3
Branches 1843 1844 +1
==========================================
+ Hits 7243 7244 +1
- Misses 203 204 +1
- Partials 124 125 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
_RemovalRepofor previous git state repo, it usesUnconfiguredTree::_pkg_filteras default pkg_filter. During thecheck for various bad file, it tries to parse the ebuild, which in
turn tries to check the usage around inherited eclasses - which
doesn't exist in this repo.
In theory, the setting of masters repo as the original one should
suffice, but it doesn't in practice. For now, let's copy the eclass
content so at least this very important check is done!