addons/git: fix interaction with git's safe.directory#421
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 95.86% 96.03% +0.16%
==========================================
Files 55 55
Lines 7666 7888 +222
Branches 1870 1963 +93
==========================================
+ Hits 7349 7575 +226
+ Misses 196 194 -2
+ Partials 121 119 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
laumann
reviewed
Aug 6, 2022
arthurzam
force-pushed
the
git-safe-directory
branch
from
2642188 to
697dd59
Compare
Member
Author
|
@thesamesam does this solution make sense for you? |
thesamesam
reviewed
Aug 7, 2022
laumann
reviewed
Aug 7, 2022
laumann
reviewed
Aug 7, 2022
Contributor
laumann
left a comment
laumann
left a comment
There was a problem hiding this comment.
Looks good, the debugging print line should probably go. Nice work.
arthurzam
force-pushed
the
git-safe-directory
branch
from
697dd59 to
1b87672
Compare
thesamesam
approved these changes
Aug 8, 2022
Member
thesamesam
left a comment
thesamesam
left a comment
There was a problem hiding this comment.
We might need to revisit whether we really want to ignore 'git log' in future (probably by revisiting git bindings in future).
Unfortunately, not that long ago at all, when radhermit tried to use the various git Python bindings out there, IIRC they were all far slower and had other limitations. But w/e.
This is what I was expecting and looks good, thanks!
When using GitLog class, it runs the git commands with clean git config, (aka it uses an empty one) which results in inability to use pkgcheck scan on overlays (as it tries to access system's gentoo repo, which is owned by root). If the user set safe.directory in his config, it will still not work, as we override user's config. Fix it by creating a temporary file, which we fill with minimal config which disables safe.directory feature, and passing it as the config file to the git log command. Resolves: #412 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
arthurzam
force-pushed
the
git-safe-directory
branch
from
1b87672 to
5c43a71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using GitLog class, it runs the git commands with clean git config, (aka it uses an empty one) which results in inability to use pkgcheck scan on overlays (as it tries to access system's gentoo repo, which is owned by root). If the user set safe.directory in his config, it will still not work, as we override user's config.
Fix it by creating a temporary file, which we fill with minimal config which disables safe.directory feature, and passing it as the config file to the git log command.
Resolves: #412