Skip to content

MissingInherits: fix false positives with unset#432

Merged
arthurzam merged 1 commit intopkgcore:masterfrom
arthurzam:fix-missing-inherit-unset
Aug 17, 2022
Merged

MissingInherits: fix false positives with unset#432
arthurzam merged 1 commit intopkgcore:masterfrom
arthurzam:fix-missing-inherit-unset

Conversation

@arthurzam
Copy link
Copy Markdown
Member

tree-sitter-bash uses type variable_name for the variable names when
unset is used. Add a special case when a variable_name is detected whose
parent is unset_command.

Resolves: #353

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 17, 2022

Codecov Report

Merging #432 (25a776b) into master (eedd7ec) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #432   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files          55       55           
  Lines        7831     7833    +2     
  Branches     2217     2218    +1     
=======================================
+ Hits         7516     7518    +2     
  Misses        194      194           
  Partials      121      121           
Impacted Files Coverage Δ
src/pkgcheck/checks/codingstyle.py 97.30% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

tree-sitter-bash uses type variable_name for the variable names when
unset is used. Add a special case when a variable_name is detected whose
parent is unset_command.

Resolves: pkgcore#353
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@arthurzam arthurzam force-pushed the fix-missing-inherit-unset branch from 25a776b to b7d2824 Compare August 17, 2022 19:26
@arthurzam arthurzam merged commit b7d2824 into pkgcore:master Aug 17, 2022
@arthurzam arthurzam deleted the fix-missing-inherit-unset branch August 17, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect MissingInherits caused by unsetting variables

1 participant