BadCommitSummary: version check should be ignored for acct-* packages#434
Merged
arthurzam merged 1 commit intopkgcore:masterfrom Aug 19, 2022
Merged
Conversation
Codecov ReportBase: 95.97% // Head: 95.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #434 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 55 55
Lines 7833 7834 +1
Branches 2218 2218
=======================================
+ Hits 7518 7519 +1
Misses 194 194
Partials 121 121
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
arthurzam
force-pushed
the
fix-BadCommitSummary
branch
from
98d3aa0 to
1ffe9a2
Compare
When doing the checks for commit summary, add an exception to the rule for acct-* packages, so the version added isn't a must for them. Resolves: pkgcore#433 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
arthurzam
force-pushed
the
fix-BadCommitSummary
branch
from
1ffe9a2 to
40ef7e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing the checks for commit summary, add an exception to the rule
for acct-* packages, so the version added isn't a must for them.
Resolves: #433