RedundantVersionCheck: consider profile masks during check#466
Merged
gentoo-bot merged 1 commit intopkgcore:masterfrom Oct 12, 2022
Merged
RedundantVersionCheck: consider profile masks during check#466gentoo-bot merged 1 commit intopkgcore:masterfrom
gentoo-bot merged 1 commit intopkgcore:masterfrom
Conversation
Codecov ReportBase: 81.13% // Head: 81.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #466 +/- ##
==========================================
+ Coverage 81.13% 81.15% +0.01%
==========================================
Files 55 55
Lines 7900 7918 +18
Branches 1765 1772 +7
==========================================
+ Hits 6410 6426 +16
Misses 1392 1392
- Partials 98 100 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
When checking for redundant version, also check that on a profile doesn't exist where the package is visible, but all later versions aren't, which means that this package isn't redundant on that profile. Resolves: pkgcore#465 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
arthurzam
force-pushed
the
fix-redundant-masks
branch
from
bbc93a3 to
6b16296
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking for redundant version, also check that on a profile doesn't exist where the package is visible, but all later versions aren't, which means that this package isn't redundant on that profile.
Resolves: #465
To Do:
RedundantVersionwe "lost" and check validity of them.