AcctCheck: use metadata/qa-policy.conf for dynamic id range#489
Merged
gentoo-bot merged 1 commit intopkgcore:masterfrom Oct 31, 2022
Merged
AcctCheck: use metadata/qa-policy.conf for dynamic id range#489gentoo-bot merged 1 commit intopkgcore:masterfrom
metadata/qa-policy.conf for dynamic id range#489gentoo-bot merged 1 commit intopkgcore:masterfrom
Conversation
Codecov ReportBase: 81.05% // Head: 81.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #489 +/- ##
==========================================
+ Coverage 81.05% 81.11% +0.05%
==========================================
Files 55 55
Lines 8040 8063 +23
Branches 1805 1810 +5
==========================================
+ Hits 6517 6540 +23
Misses 1425 1425
Partials 98 98
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
thesamesam
reviewed
Oct 30, 2022
arthurzam
force-pushed
the
id-ranges-file
branch
from
d5ce3ab to
37ce04b
Compare
thesamesam
approved these changes
Oct 31, 2022
arthurzam
force-pushed
the
id-ranges-file
branch
from
37ce04b to
894a7b5
Compare
thesamesam
reviewed
Oct 31, 2022
Load UID and GID range from metadata/qa-policy.conf under the repo, validate the format is as expected, and use the values to set expected ids. Resolves: pkgcore#356 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
arthurzam
force-pushed
the
id-ranges-file
branch
from
894a7b5 to
4e69c9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load UID and GID range from
metadata/qa-policy.confunder the repo, validate the format is as expected, and use the values to set expected ids.Resolves: #356
I mainly need a review of the class' docs changes I did, that they are sane.