Skip to content

purer setuptools#494

Merged
gentoo-bot merged 4 commits intopkgcore:masterfrom
arthurzam:new-setuptools
Nov 19, 2022
Merged

purer setuptools#494
gentoo-bot merged 4 commits intopkgcore:masterfrom
arthurzam:new-setuptools

Conversation

@arthurzam
Copy link
Copy Markdown
Member

As part of pkgcore/snakeoil#77 , use purer setuptools setup. Some of the big changes:

  1. Wheel are python ABI agnostic. While platform specific, they don't link/include python stuff (just tree-sitter-bash), so the library is python agnostic, and we can create a "universal" wheel per platform.
  2. I use new snakeoil sphinx extension for man/html generation - removes all logic from doc/conf.py
  3. Add CI workflow to release.yml to create platform wheels for arm64, ppc64le, s390x, for both musl and glibc
  4. Add makefile for easier work with the various commands
  5. Enable testing directly using pytest command, and not using setup.py test

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 16, 2022

Codecov Report

Base: 80.97% // Head: 80.94% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (4216a70) compared to base (d77990e).
Patch coverage: 66.66% of modified lines in pull request are covered.

❗ Current head 4216a70 differs from pull request most recent head 5fd8dca. Consider uploading reports for the commit 5fd8dca to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
- Coverage   80.97%   80.94%   -0.04%     
==========================================
  Files          55       55              
  Lines        8123     8125       +2     
  Branches     1826     1825       -1     
==========================================
- Hits         6578     6577       -1     
- Misses       1446     1449       +3     
  Partials       99       99              
Impacted Files Coverage Δ
src/pkgcheck/scripts/__init__.py 88.88% <50.00%> (-11.12%) ⬇️
src/pkgcheck/const.py 100.00% <100.00%> (ø)
src/pkgcheck/scripts/pkgcheck_scan.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arthurzam arthurzam force-pushed the new-setuptools branch 2 times, most recently from 673848e to 0042d1b Compare November 16, 2022 18:30
@thesamesam thesamesam requested a review from mgorny November 16, 2022 19:22
Copy link
Copy Markdown
Contributor

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a cursory look for now.

Comment thread pyproject.toml
requires = [
"wheel", "setuptools",
"setuptools",
"wheel",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the explicit wheel dep?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprisingly enough, I do indeed use wheel, to mark my wheel as python ABI agnostic
The usage is with the line:

from wheel.bdist_wheel import bdist_wheel as orig_bdist_wheel

...

class bdist_wheel(orig_bdist_wheel):
    ...

Comment thread pyproject.toml Outdated
@arthurzam arthurzam requested a review from mgorny November 19, 2022 13:34
Copy link
Copy Markdown
Contributor

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@gentoo-bot gentoo-bot merged commit 5fd8dca into pkgcore:master Nov 19, 2022
@arthurzam arthurzam deleted the new-setuptools branch November 19, 2022 16:59
@gentoo-bot gentoo-bot temporarily deployed to github-pages November 19, 2022 17:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants