Skip to content

GitPkgCommitsCheck: catch SRC_URI mistakes#497

Merged
gentoo-bot merged 1 commit intopkgcore:masterfrom
arthurzam:commit-src_uri
Jan 20, 2023
Merged

GitPkgCommitsCheck: catch SRC_URI mistakes#497
gentoo-bot merged 1 commit intopkgcore:masterfrom
arthurzam:commit-src_uri

Conversation

@arthurzam
Copy link
Copy Markdown
Member

@arthurzam arthurzam commented Nov 26, 2022

Currently it is in first stages, which need a lot of work:

  • add tests
  • cleanup and improve the strings for description and texts

Resolves: #493

@thesamesam
Copy link
Copy Markdown
Member

Could you rebase then I'll take a look?

Resolves: pkgcore#493
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 20, 2023

Codecov Report

Base: 80.86% // Head: 80.92% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (09559c0) compared to base (086e4eb).
Patch coverage: 92.10% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
+ Coverage   80.86%   80.92%   +0.06%     
==========================================
  Files          56       56              
  Lines        8214     8251      +37     
  Branches     1849     1858       +9     
==========================================
+ Hits         6642     6677      +35     
- Misses       1473     1474       +1     
- Partials       99      100       +1     
Impacted Files Coverage Δ
src/pkgcheck/checks/git.py 97.17% <92.10%> (-0.51%) ⬇️
src/pkgcheck/runners.py 92.98% <0.00%> (+1.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gentoo-bot gentoo-bot merged commit 09559c0 into pkgcore:master Jan 20, 2023
@arthurzam arthurzam deleted the commit-src_uri branch January 20, 2023 20:47
@gentoo-bot gentoo-bot temporarily deployed to github-pages January 20, 2023 20:48 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add commit check for SRC_URI URL changing without new distfile name

3 participants