ProfilesCheck: make.defaults checks

[arthurzam]

Resolves: #524

PMS

A big cluster of the various checks, and results for make.defaults in profiles

Totally it added this results:

33 results in ::gentoo tree

UnknownProfileUse: 'arch/alpha/make.defaults': unknown USE flag: 'libtirpc'
UnknownProfileUse: 'arch/amd64/make.defaults': unknown USE flag: 'libtirpc'
UnknownProfileUse: 'arch/arm64/make.defaults': unknown USE flag: 'libtirpc'
UnknownProfileUse: 'arch/ia64/make.defaults': unknown USE flag: 'libtirpc'
UnknownProfileUse: 'arch/powerpc/ppc32/make.defaults': unknown USE flag: 'abi_ppc_32'
UnknownProfileUse: 'arch/powerpc/ppc64/32ul/make.defaults': unknown USE flags: 'abi_ppc_32', 'abi_ppc_64'
UnknownProfileUse: 'arch/powerpc/ppc64/make.defaults': unknown USE flag: 'abi_ppc_64'
UnknownProfileUse: 'arch/sparc/make.defaults': unknown USE flag: 'libtirpc'
UnknownProfileUse: 'arch/x86/make.defaults': unknown USE flag: 'libtirpc'
UnknownProfileUse: 'base/make.defaults': unknown USE flag: 'nptl'
UnknownProfileUse: 'default/linux/make.defaults': unknown USE flag: 'cli'
UnknownProfileUse: 'embedded/make.defaults': unknown USE flags: 'kdrive', 'multicall'
UnknownProfileUse: 'features/hardened/amd64/make.defaults': unknown USE flag: 'pic'
UnknownProfileUse: 'features/hardened/amd64/no-multilib/make.defaults': unknown USE flag: 'pic'
UnknownProfileUse: 'features/hardened/arm/make.defaults': unknown USE flag: 'pic'
UnknownProfileUse: 'features/hardened/arm64/make.defaults': unknown USE flag: 'pic'
UnknownProfileUse: 'features/hardened/make.defaults': unknown USE flags: 'pic', 'ptpax', 'xtpax'
UnknownProfileUse: 'features/hardened/x86/make.defaults': unknown USE flag: 'pic'
UnknownProfileUse: 'features/musl/make.defaults': unknown USE flag: 'nptl'
UnknownProfileUse: 'prefix/darwin/macos/arch/ppc/make.defaults': unknown USE flag: 'abi_ppc_32'
UnknownProfileUse: 'prefix/darwin/macos/make.defaults': unknown USE flags: 'objc', 'objc++'
UnknownProfileUse: 'releases/23.0/make.defaults': unknown USE flag: 'cli'
UnknownProfileUse: 'targets/desktop/gnome/make.defaults': unknown USE flags: 'evo', 'gnome-online-accounts', 'libsecret', 'nautilus', 'sysprof', 'tracker'
UnknownProfileUse: 'targets/desktop/make.defaults': unknown USE flag: 'pango'
UnknownProfileUse: 'targets/desktop/plasma/make.defaults': unknown USE flags: 'activities', 'declarative', 'kwallet', 'qml', 'widgets'
UnknownProfileUseExpand: 'arch/loong/make.defaults': unknown USE_EXPAND group in 'USE_EXPAND_VALUES_ARCH': ARCH
UnknownProfileUseExpandValue: 'arch/mips/make.defaults': unknown value for 'VIDEO_CARDS': impact
UnknownProfileUseExpandValue: 'base/make.defaults': unknown values for 'APACHE2_MODULES': authn_alias, authn_default, authz_default, disk_cache, mem_cache
UnknownProfileUseExpandValue: 'base/make.defaults': unknown values for 'GPSD_PROTOCOLS': nmea, oldstyle, timing, ubx
UnknownProfileUseExpandValue: 'base/make.defaults': unknown values for 'LCD_DEVICES': cfontz633, ncurses
UnknownProfileUseExpandValue: 'base/make.defaults': unknown values for 'LIBREOFFICE_EXTENSIONS': presenter-console, presenter-minimizer
UnknownProfileUseExpandValue: 'base/make.defaults': unknown values for 'XTABLES_ADDONS': ipset, rawnat, steal, tee
UnknownProfileUseExpandValue: 'default/linux/make.defaults': unknown value for 'VIDEO_CARDS': v4l

Tests are included for all the changes here. Just a quick review of English is needed.

[codecov]

Codecov Report

Base: 80.99% // Head: 80.92% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (191300b) compared to base (d10bd72).
Patch coverage: 60.31% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
- Coverage   80.99%   80.92%   -0.08%     
==========================================
  Files          56       56              
  Lines        8141     8194      +53     
  Branches     1826     1842      +16     
==========================================
+ Hits         6594     6631      +37     
- Misses       1448     1464      +16     
  Partials       99       99              

Impacted Files	Coverage Δ
src/pkgcheck/checks/profiles.py	63.53% <59.67%> (+1.11%)	⬆️
src/pkgcheck/addons/__init__.py	90.81% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ferringb]

Any thoughts on moving the concept of use_expand groups into pkgcore itself? We've got multiple spots that are now hardcoding how to split them. Seems like something where an object representation might be of value.

[arthurzam]

I will create a shared impl in pkgcore, but for now I don't won't to be blocked until pkgcore release, so for now duplication of code, until I introduce the new shared code.

[ferringb]

No worries. My comment is more an observation I did something similar in portage_conf for use_expand, so it's probably time one of us cuts a class to hold the rules for it. ;)