ArchesMisSync: check for arch.list <-> arches.desc missync#529
Merged
gentoo-bot merged 1 commit intopkgcore:masterfrom Jan 20, 2023
Merged
ArchesMisSync: check for arch.list <-> arches.desc missync#529gentoo-bot merged 1 commit intopkgcore:masterfrom
gentoo-bot merged 1 commit intopkgcore:masterfrom
Conversation
Codecov ReportBase: 80.86% // Head: 80.85% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 80.86% 80.85% -0.01%
==========================================
Files 56 56
Lines 8200 8212 +12
Branches 1844 1847 +3
==========================================
+ Hits 6631 6640 +9
- Misses 1470 1473 +3
Partials 99 99
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
thesamesam
reviewed
Jan 19, 2023
mgorny
approved these changes
Jan 20, 2023
Contributor
mgorny
left a comment
mgorny
left a comment
There was a problem hiding this comment.
LGTM, though sam is probably right about the name.
| if unused_profile_dirs := available_profile_dirs - seen_profile_dirs: | ||
| yield UnusedProfileDirs(sorted(unused_profile_dirs)) | ||
|
|
||
| if arches_desc := frozenset().union(*self.repo.config.arches_desc.values()): |
Contributor
There was a problem hiding this comment.
Nice trick. I'd have used itertools.chain() myself.
Resolves: pkgcore#526 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
arthurzam
force-pushed
the
check-arches
branch
from
f3dec24 to
72ec9a3
Compare
gentoo-bot
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #526