pkp/pkp-lib#11125 Fix: Copyediting Stage, Discussion tags do not populate [main] #1918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taslangraham
changed the title
Closed
1 task
taslangraham
force-pushed
the
i11125-main
branch
from
795eed8 to
9cdaefe
Compare
taslangraham
force-pushed
the
i11125-main
branch
from
9cdaefe to
6e69aa9
Compare
taslangraham
force-pushed
the
i11125-main
branch
3 times, most recently
from
4f32c8f to
cb02f30
Compare
ewhanson
requested changes
May 27, 2025
Contributor
ewhanson
left a comment
ewhanson
left a comment
There was a problem hiding this comment.
Same comment about blank lines between locale entries as in stable-3_5_0. Otherwise looks good.
|
|
||
| msgid "notification.type.editorAssignmentTask" | ||
| msgstr "" | ||
|
|
Contributor
There was a problem hiding this comment.
One blank line needed between the entries for all locale files.
taslangraham
force-pushed
the
i11125-main
branch
2 times, most recently
from
c67adbe to
6a0ee00
Compare
Contributor
|
@taslangraham, could you squash the "code refactor" commit into one of the others and double check the failing tests? It's not consistent but does seem to be happening across the applications/branches with the upgrade tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pkp/pkp-lib#11125